From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([65.50.211.133]:60345 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753648AbdKJT3J (ORCPT ); Fri, 10 Nov 2017 14:29:09 -0500 Date: Fri, 10 Nov 2017 11:29:02 -0800 From: Matthew Wilcox To: "Fu, Rodney" Cc: "hch@lst.de" , "viro@zeniv.linux.org.uk" , "linux-fsdevel@vger.kernel.org" Subject: Re: Provision for filesystem specific open flags Message-ID: <20171110192902.GA10339@bombadil.infradead.org> References: <20171110172344.GA15288@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Nov 10, 2017 at 05:39:21PM +0000, Fu, Rodney wrote: > > Absolutely against. Open flags need to be defined in common code or you are in a massive world of trouble. > > I'm suggesting this can be done with definitions in common code via generically named open flags. Say for example if there was defined an O_FS1, O_FS2 (someone pick a better name) exposed for an application to use that has no meaning to the VFS layer, but could be interpreted by the filesystem. Could that work? No. If you want new flags bits, make a public proposal. Maybe some other filesystem would also benefit from them.