From: Christoph Hellwig <hch@lst.de>
To: Jeff Layton <jlayton@kernel.org>
Cc: linux-fsdevel@vger.kernel.org, Vitaly Lipatov <lav@etersoft.ru>,
hch@lst.de, bfields@fieldses.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] fcntl: don't cap l_start and l_end values for F_GETLK64 in compat syscall
Date: Fri, 17 Nov 2017 19:41:42 +0100 [thread overview]
Message-ID: <20171117184142.GA28617@lst.de> (raw)
In-Reply-To: <20171115180345.8219-1-jlayton@kernel.org>
On Wed, Nov 15, 2017 at 01:03:45PM -0500, Jeff Layton wrote:
> From: Jeff Layton <jlayton@redhat.com>
>
> Currently, we're capping the values too low in the F_GETLK64 case. The
> fields in that structure are 64-bit values, so we shouldn't need to do
> any sort of fixup there.
>
> Make sure we check that assumption at build time in the future however
> by ensuring that the sizes we're copying will fit.
>
> With this, we no longer need COMPAT_OFF_T_MAX either, so remove it.
Sounds like the COMPAT_LOFF_T_MAX should be a separate patch, but otherwise
this looks good.
Reviewed-by: Christoph Hellwig <hch@lst.de>
Btw, I seems like arm has another copy of the old broken compat
code in arch/arm/kernel/sys_oabi-compat.c. I wonder if anyone with
a vested interest in arm would be willing to clean that mess up.
prev parent reply other threads:[~2017-11-17 18:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 18:03 [PATCH v2] fcntl: don't cap l_start and l_end values for F_GETLK64 in compat syscall Jeff Layton
2017-11-15 18:31 ` Vitaly Lipatov
2017-11-16 11:51 ` Jeff Layton
2017-11-17 18:41 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171117184142.GA28617@lst.de \
--to=hch@lst.de \
--cc=bfields@fieldses.org \
--cc=jlayton@kernel.org \
--cc=lav@etersoft.ru \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).