From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zeniv.linux.org.uk ([195.92.253.2]:47986 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751152AbdKSV2v (ORCPT ); Sun, 19 Nov 2017 16:28:51 -0500 Date: Sun, 19 Nov 2017 21:28:49 +0000 From: Al Viro To: Tim Hansen Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Torvalds Subject: Re: [PATCH] fs: Safe rcu access to hlist. Message-ID: <20171119212849.GV21978@ZenIV.linux.org.uk> References: <20171119200210.hhrklgm6hxhoyhqh@debian> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171119200210.hhrklgm6hxhoyhqh@debian> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sun, Nov 19, 2017 at 03:02:10PM -0500, Tim Hansen wrote: > Adds hlist_first_rcu and hlist_next_rcu for safe access > to the hlist in seq_hlist_next_rcu. > > Found on linux-next branch, tag next-20171117 with sparse. Frankly, I'm tempted to take sparse RCU annotations out for good - they are far too noisy and I'm not sure sparse is suitable for the analysis needed to prove safety of that stuff, so unless you (or somebody else) figures out how to use them in a reasonably clean way, we'd probably be better off just dropping them.