From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com ([134.134.136.65]:1361 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751845AbdK1V5w (ORCPT ); Tue, 28 Nov 2017 16:57:52 -0500 Date: Tue, 28 Nov 2017 23:57:53 +0200 From: Jarkko Sakkinen To: Christoph Hellwig Cc: platform-driver-x86@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, Alexander Viro , "open list:FILESYSTEMS (VFS and infrastructure)" Subject: Re: [PATCH v6 09/11] fs/pipe.c: export create_pipe_files() and replace_fd() Message-ID: <20171128215753.qnu5krswowjq6gwn@linux.intel.com> References: <20171125193132.24321-1-jarkko.sakkinen@linux.intel.com> <20171125193132.24321-10-jarkko.sakkinen@linux.intel.com> <20171128143504.GA22918@infradead.org> <20171128204220.j7ipouoyhsbvm7zk@linux.intel.com> <20171128210551.GA12431@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171128210551.GA12431@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Nov 28, 2017 at 01:05:51PM -0800, Christoph Hellwig wrote: > On Tue, Nov 28, 2017 at 10:42:20PM +0200, Jarkko Sakkinen wrote: > > On Tue, Nov 28, 2017 at 06:35:04AM -0800, Christoph Hellwig wrote: > > > Repeated NAK - any interface that deals with raw file descriptor table > > > entries has absolutely no business in a driver. > > > > > > Please fix your API already. > > > > Does it make a differnece if the code is moved to arch/x86, which could > > potentially happen (see Darren's and tglx's comments on v5)? Then the > > need for export will be gone. > > Yes. You still shall not play nasty games with file descriptors. I need to put something to file descriptors in order to have a IO channels for the launch enclave hosting process. /Jarkko