From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:54450 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750849AbdK3Uuw (ORCPT ); Thu, 30 Nov 2017 15:50:52 -0500 Date: Thu, 30 Nov 2017 12:50:50 -0800 From: Andrew Morton To: Christoph Hellwig Cc: Ingo Molnar , eter Zijlstra , Al Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: waitqueue lockdep annotation Message-Id: <20171130125050.1faba3f06fc572846f792f17@linux-foundation.org> In-Reply-To: <20171130142037.19339-1-hch@lst.de> References: <20171130142037.19339-1-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, 30 Nov 2017 06:20:35 -0800 Christoph Hellwig wrote: > Hi all, > > this series adds a strategic lockdep_assert_held to __wake_up_common > to ensure callers really do hold the wait_queue_head lock when calling > the unlocked wake_up variants. It turns out epoll did not do this > for a fairly common path (hit all the time by systemd during bootup), > so the second patch fixed this instance as well. What are the runtime effects of the epoll bug?