From: Christoph Hellwig <hch@lst.de>
To: Ingo Molnar <mingo@redhat.com>, eter Zijlstra <peterz@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] epoll: use proper wake_up variant in ep_poll_callback
Date: Thu, 30 Nov 2017 06:20:37 -0800 [thread overview]
Message-ID: <20171130142037.19339-3-hch@lst.de> (raw)
In-Reply-To: <20171130142037.19339-1-hch@lst.de>
We do not hold ep->wq->lock, so we should not use wake_up_locked on it.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
fs/eventpoll.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/eventpoll.c b/fs/eventpoll.c
index afd548ebc328..eaaa39616232 100644
--- a/fs/eventpoll.c
+++ b/fs/eventpoll.c
@@ -1190,7 +1190,7 @@ static int ep_poll_callback(wait_queue_entry_t *wait, unsigned mode, int sync, v
break;
}
}
- wake_up_locked(&ep->wq);
+ wake_up(&ep->wq);
}
if (waitqueue_active(&ep->poll_wait))
pwake++;
--
2.14.2
next prev parent reply other threads:[~2017-11-30 14:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 14:20 waitqueue lockdep annotation Christoph Hellwig
2017-11-30 14:20 ` [PATCH 1/2] sched/wait: assert the wait_queue_head lock is held in __wake_up_common Christoph Hellwig
2017-11-30 14:20 ` Christoph Hellwig [this message]
2017-11-30 20:50 ` waitqueue lockdep annotation Andrew Morton
2017-11-30 21:38 ` Jason Baron
2017-11-30 22:11 ` Christoph Hellwig
2017-11-30 22:18 ` Jason Baron
2017-12-01 17:11 ` Christoph Hellwig
2017-12-01 19:00 ` Jason Baron
2017-12-01 22:02 ` Christoph Hellwig
2017-12-01 22:34 ` Jason Baron
2017-12-01 23:03 ` Christoph Hellwig
2017-12-05 15:24 ` Jason Baron
2017-12-05 15:36 ` Davidlohr Bueso
2017-12-06 23:51 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171130142037.19339-3-hch@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).