linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Michal Hocko <mhocko@kernel.org>
Cc: Dave Chinner <david@fromorbit.com>, Jan Kara <jack@suse.cz>,
	Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-fsdevel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2] fs: handle shrinker registration failure in sget_userns
Date: Sat, 9 Dec 2017 21:54:22 +0000	[thread overview]
Message-ID: <20171209215422.GN21978@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20171209205922.GM21978@ZenIV.linux.org.uk>

On Sat, Dec 09, 2017 at 08:59:22PM +0000, Al Viro wrote:
> On Wed, Nov 29, 2017 at 12:55:15PM +0100, Michal Hocko wrote:
> > On Thu 23-11-17 14:55:40, Al Viro wrote:
> > > On Thu, Nov 23, 2017 at 03:35:37PM +0100, Michal Hocko wrote:
> > > > Hopefully less screwed version.  But as I've said I am not really
> > > > familiar with the code and do not feel competent to change it so please
> > > > be very careful here. I've moved the shrinker registration to
> > > > alloc_super which turned out to be simpler.
> > > 
> > > I don't get it.  Why the hell do we need all that PITA in the first place?
> > > Just make sget_userns() end with
> > > 	if (unlikely(regsiter_shrinker(&s->s_shrink) != 0)) {
> > > 		deactivate_locked_super(s);
> > > 		s = ERR_PTR(-ENOMEM);
> > > 	}
> > > 	return s;
> > > and be done with that.  All there is to it...
> > 
> > Al, do you plan to push this fix? Tetsuo's unregister_shrinker
> > fortification is already in the mmotm tree.
> 
> Is it in any git branch I could pull from?  Or I could just throw it
> into vfs.git#for-linus before the fix above - up to you, folks...

Actually, looking at mmotm...  I don't see it there.  Which patch
is it in?

  reply	other threads:[~2017-12-09 21:54 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-23 11:52 [PATCH] fs: handle shrinker registration failure in sget_userns Michal Hocko
2017-11-23 12:26 ` Jan Kara
2017-11-23 12:45   ` Michal Hocko
2017-11-23 12:53     ` Michal Hocko
2017-11-23 12:56       ` Jan Kara
2017-11-23 13:35         ` Tetsuo Handa
2017-11-23 13:46           ` Michal Hocko
2017-11-23 13:57             ` Tetsuo Handa
2017-11-23 14:06               ` Michal Hocko
2017-11-23 14:10                 ` Tetsuo Handa
2017-11-23 14:35 ` [PATCH v2] " Michal Hocko
2017-11-23 14:55   ` Al Viro
2017-11-23 15:02     ` Michal Hocko
2017-11-23 15:34       ` Michal Hocko
2017-11-23 15:04     ` [PATCH v2] fs: handle shrinker registration failure insget_userns Tetsuo Handa
2017-11-23 15:28       ` Al Viro
2017-11-23 15:35         ` [PATCH v2] fs: handle shrinker registration failure in sget_userns Tetsuo Handa
2017-11-23 15:44           ` Al Viro
2017-11-23 21:51             ` Tetsuo Handa
2017-11-24  7:48               ` Michal Hocko
2017-11-29 11:55     ` Michal Hocko
2017-12-09 20:59       ` Al Viro
2017-12-09 21:54         ` Al Viro [this message]
2017-12-10  2:33           ` Tetsuo Handa
2017-12-10 10:05             ` Michal Hocko
2017-12-10 15:21               ` Al Viro
2017-11-23 14:47 ` [PATCH] " Al Viro
2017-11-23 15:00   ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171209215422.GN21978@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=akpm@linux-foundation.org \
    --cc=david@fromorbit.com \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhocko@kernel.org \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).