From: Eric Biggers <ebiggers3@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: syzbot
<bot+f7b85b77fd8042059586165494cd708475e87fc3@syzkaller.appspotmail.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
syzkaller-bugs@googlegroups.com, viro@zeniv.linux.org.uk
Subject: Re: general protection fault in string
Date: Tue, 12 Dec 2017 09:58:47 -0800 [thread overview]
Message-ID: <20171212175847.GA582@zzz.localdomain> (raw)
In-Reply-To: <alpine.DEB.2.20.1712121808120.1794@nanos>
On Tue, Dec 12, 2017 at 06:11:09PM +0100, Thomas Gleixner wrote:
> >
> > I wonder if anything would break if we made sys_timer_create() return -EINVAL
> > for unrecognized values of sigev_notify? That's what it *should* do, but it
> > seems to be the classic "unchecked flags" bug, yet again...
>
> So this is the 5th time this comes up and I sent a patch the first time. No
> answer since than just more repeating reports.
>
> https://marc.info/?l=linux-kernel&m=151204669103208&w=2
>
> Thanks,
>
> tglx
Are you expecting an answer from syzbot? It is just a bot so it cannot review
or apply patches. There is a way to ask it to test a patch (see
https://github.com/google/syzkaller/blob/master/docs/syzbot.md) though it only
works for bugs with reproducers, and when fixing bugs I've personally found it
easier (and often necessary to debug the problem in the first place) to just run
the reproducer myself. Note that syzbot *did* provide a C reproducer for this
report, and also a C reproducer for the original report after a short delay, so
you could run those as well as my simplified reproducer to verify the bug is
fixed -- though given my investigation your patch very likely does fix the bug.
Keep in mind that you can't expect that a human "behind the scenes" will quickly
step in and help review/test the fixes for syzbot bugs either. Ideally that
*would* happen, but there are simply too many open bugs (200+) and syzbot is
operated primarily by just one person, Dmitry Vyukov. I've been helping out
with some bugs I am interested in and I will get to as many as I can but there
are far too many for even 2 people. So the community needs to help out. Again,
see the docs at https://github.com/google/syzkaller/blob/master/docs/syzbot.md
for how to communicate with the bot and tell it when a bug is a dup, when a bug
is fixed, or how to test a patch, etc.
Eric
prev parent reply other threads:[~2017-12-12 17:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <001a1143e6ccdb8581055f499952@google.com>
2017-12-03 5:10 ` general protection fault in string syzbot
2017-12-11 23:03 ` Eric Biggers
2017-12-11 23:11 ` Eric Biggers
2017-12-12 17:11 ` Thomas Gleixner
2017-12-12 17:58 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171212175847.GA582@zzz.localdomain \
--to=ebiggers3@gmail.com \
--cc=bot+f7b85b77fd8042059586165494cd708475e87fc3@syzkaller.appspotmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).