From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 14 Dec 2017 14:06:51 +0100 From: Christoph Hellwig To: Ingo Molnar Cc: Christoph Hellwig , Peter Zijlstra , Ingo Molnar , Peter Zijlstra , Andrew Morton , Al Viro , Jason Baron , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] epoll: use the waitqueue lock to protect ep->wq Message-ID: <20171214130651.GB10791@lst.de> References: <20171206235230.19425-1-hch@lst.de> <20171206235230.19425-2-hch@lst.de> <20171207004914.lxu2dz6cmxgnrou3@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171207004914.lxu2dz6cmxgnrou3@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: > Hm, that reads a bit weirdly. How about: > > The epoll code currently uses the unlocked waitqueue helpers for managing > ep->wq, but instead of holding the waitqueue lock around these calls, it > uses its own ep->lock spinlock. Thanks, fixed.