From: Matthew Wilcox <willy@infradead.org>
To: NeilBrown <neilb@suse.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>,
"J. Bruce Fields" <bfields@fieldses.org>,
Trond Myklebust <trond.myklebust@primarydata.com>,
Anna Schumaker <Anna.Schumaker@netapp.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH/RFC] VFS: don't keep disconnected dentries on d_anon
Date: Wed, 20 Dec 2017 14:56:04 -0800 [thread overview]
Message-ID: <20171220225604.GA2980@bombadil.infradead.org> (raw)
In-Reply-To: <87y3lxj9wr.fsf@notabene.neil.brown.name>
On Thu, Dec 21, 2017 at 09:45:40AM +1100, NeilBrown wrote:
> -c/ Helper routines to allocate anonymous dentries, and to help attach
> + prefix. If the refcount on a dentry with this flag set
> + becomes zero, the dentry is immediately discarded, rather than being
> + kept in the dcache. If a dentry that is not already in the dcache
> + is repeatedly accessed by filehandle (as NFSD might do), an new dentry
> + will be a allocated for each access, and discarded at the end of
s/a //
> + the access. As there is no parent, children, or name in the dentry
> + is it unlikely that there will be any useful information to lose,
> + and allocating a new dentry should normally be fast.
How about:
As the dentry is completely unattached, there is little information to
lose, and allocating a new dentry is normally fast.
next prev parent reply other threads:[~2017-12-20 22:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 22:45 [PATCH/RFC] VFS: don't keep disconnected dentries on d_anon NeilBrown
2017-12-20 22:56 ` Matthew Wilcox [this message]
2017-12-20 23:13 ` NeilBrown
2017-12-20 23:16 ` Al Viro
2017-12-21 0:57 ` Linus Torvalds
2017-12-21 5:40 ` Al Viro
-- strict thread matches above, loose matches on Subject: below --
2017-12-20 22:45 NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171220225604.GA2980@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=Anna.Schumaker@netapp.com \
--cc=bfields@fieldses.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.com \
--cc=torvalds@linux-foundation.org \
--cc=trond.myklebust@primarydata.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).