From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com ([134.134.136.24]:12542 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751865AbdLURRD (ORCPT ); Thu, 21 Dec 2017 12:17:03 -0500 Date: Thu, 21 Dec 2017 10:17:01 -0700 From: Ross Zwisler To: Jan Kara Cc: linux-ext4@vger.kernel.org, Ted Tso , Ross Zwisler , Dan Williams , linux-fsdevel@vger.kernel.org, linux-nvdimm@lists.01.org Subject: Re: [PATCH 2/2] ext4: Fix ENOSPC handling in DAX page fault handler Message-ID: <20171221171701.GC2158@linux.intel.com> References: <20171221163055.3943-1-jack@suse.cz> <20171221163055.3943-3-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171221163055.3943-3-jack@suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Dec 21, 2017 at 05:30:55PM +0100, Jan Kara wrote: > When allocation of underlying block for a page fault fails, we fail the > fault with SIGBUS. However we may well hit ENOSPC just due to lots of > free blocks being held by the running / committing transaction. So > propagate the error from ext4_iomap_begin() and implement do standard > allocation retry loop in ext4_dax_huge_fault(). > > Signed-off-by: Jan Kara Looks good. Reviewed-by: Ross Zwisler