From: Al Viro <viro@ZenIV.linux.org.uk>
To: Eric Biggers <ebiggers3@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Davide Libenzi <davidel@xmailserver.org>
Subject: Re: [PATCH 0/3] eventfd: clean up unneeded cruft
Date: Sat, 6 Jan 2018 19:00:48 +0000 [thread overview]
Message-ID: <20180106190048.GG21978@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20180106184619.GF21978@ZenIV.linux.org.uk>
On Sat, Jan 06, 2018 at 06:46:19PM +0000, Al Viro wrote:
> On Sat, Jan 06, 2018 at 09:45:41AM -0800, Eric Biggers wrote:
> > This series removes some cruft (mainly exported functions) from
> > fs/eventfd.c which seems to have been added while the KVM irqfd feature
> > was under development some years ago, but was never actually used.
>
> Applied.
Said that, is there any reason for keeping e.g. vhost_dev->log_file around?
We already keep ->log_ctx, so... Ditto for vq->call and vq->error,
and if we did it for vq->kick as well, we'd be able to get rid of
separate eventfd_fget() as well.
next prev parent reply other threads:[~2018-01-06 19:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-06 17:45 [PATCH 0/3] eventfd: clean up unneeded cruft Eric Biggers
2018-01-06 17:45 ` [PATCH 1/3] eventfd: convert to use anon_inode_getfd() Eric Biggers
2018-01-06 17:45 ` [PATCH 2/3] eventfd: fold eventfd_ctx_read() into eventfd_read() Eric Biggers
2018-01-06 17:45 ` [PATCH 3/3] eventfd: fold eventfd_ctx_get() into eventfd_ctx_fileget() Eric Biggers
2018-01-06 18:46 ` [PATCH 0/3] eventfd: clean up unneeded cruft Al Viro
2018-01-06 19:00 ` Al Viro [this message]
2018-01-06 21:53 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180106190048.GG21978@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=davidel@xmailserver.org \
--cc=ebiggers3@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).