From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:39804 "EHLO
        ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751219AbeAFTAt (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Sat, 6 Jan 2018 14:00:49 -0500
Date: Sat, 6 Jan 2018 19:00:48 +0000
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Eric Biggers <ebiggers3@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Davide Libenzi <davidel@xmailserver.org>
Subject: Re: [PATCH 0/3] eventfd: clean up unneeded cruft
Message-ID: <20180106190048.GG21978@ZenIV.linux.org.uk>
References: <20180106174544.5331-1-ebiggers3@gmail.com>
 <20180106184619.GF21978@ZenIV.linux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180106184619.GF21978@ZenIV.linux.org.uk>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Sat, Jan 06, 2018 at 06:46:19PM +0000, Al Viro wrote:
> On Sat, Jan 06, 2018 at 09:45:41AM -0800, Eric Biggers wrote:
> > This series removes some cruft (mainly exported functions) from
> > fs/eventfd.c which seems to have been added while the KVM irqfd feature
> > was under development some years ago, but was never actually used.
> 
> Applied.


Said that, is there any reason for keeping e.g. vhost_dev->log_file around?
We already keep ->log_ctx, so...  Ditto for vq->call and vq->error,
and if we did it for vq->kick as well, we'd be able to get rid of
separate eventfd_fget() as well.