From: Rakesh Pandit <rakesh@tuxera.com>
To: Jan Kara <jack@suse.cz>
Cc: <linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Alexander Viro" <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] vfs: remove unused argument in iterate_bdevs
Date: Thu, 11 Jan 2018 17:18:11 +0200 [thread overview]
Message-ID: <20180111151811.GA11277@dhcp-108-107.ws.tuxera.com> (raw)
In-Reply-To: <20180111150645.wqiz4zpklabriymh@quack2.suse.cz>
On Thu, Jan 11, 2018 at 04:06:45PM +0100, Jan Kara wrote:
> On Thu 11-01-18 16:04:07, Rakesh Pandit wrote:
> > @@ -2472,7 +2472,7 @@ static inline int thaw_bdev(struct block_device *bdev, struct super_block *sb)
> > return 0;
> > }
> >
> > -static inline void iterate_bdevs(void (*f)(struct block_device *, void *), void *arg)
> > +static inline void iterate_bdevs(void (*f)(struct block_device *, void *))
>
> You've missed the void * in (*f) prototype here. Other than that:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
Thanks for catching it. I would repost with your tag and fix it same time.
next prev parent reply other threads:[~2018-01-11 15:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 14:04 [PATCH] vfs: remove unused argument in iterate_bdevs Rakesh Pandit
2018-01-11 15:06 ` Jan Kara
2018-01-11 15:18 ` Rakesh Pandit [this message]
2018-01-11 15:31 ` Al Viro
2018-01-14 15:07 ` kbuild test robot
2018-01-14 16:13 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180111151811.GA11277@dhcp-108-107.ws.tuxera.com \
--to=rakesh@tuxera.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).