From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([65.50.211.133]:51883 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754833AbeAMMsn (ORCPT ); Sat, 13 Jan 2018 07:48:43 -0500 Date: Sat, 13 Jan 2018 04:48:42 -0800 From: Matthew Wilcox To: Chandan Rajendra Cc: Randy Dunlap , linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, tytso@mit.edu Subject: Re: [RFC PATCH 0/8] Ext4 encryption support for blocksize < pagesize Message-ID: <20180113124842.GA15364@bombadil.infradead.org> References: <20180112141129.27507-1-chandan@linux.vnet.ibm.com> <1aa4981a-63ef-aaa4-97da-9c9137d52862@infradead.org> <4200254.IvU45QXq6O@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4200254.IvU45QXq6O@localhost.localdomain> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sat, Jan 13, 2018 at 10:58:00AM +0530, Chandan Rajendra wrote: > On Saturday, January 13, 2018 12:37:59 AM IST Randy Dunlap wrote: > > On 01/12/18 06:11, Chandan Rajendra wrote: > > > This patchset implements code to support encryption of Ext4 filesystem > > > instances that have blocksize less than pagesize. The patchset has > > > been tested on both ppc64 and x86_64 machines. > > > > strictly "less than" or "less than or equal to"? > > I have tested the patchset for the use cases of "less than or equal to > page size" i.e. On ppc64, the patchset was tested with blocksizes of > 4k and 64k. On x86_64, the patchset was tested with blocksizes of 2k > and 4k. I think there's a miscommunication here. ext4 already supports encryption of filesystems with block size == page size. Chandan is adding support for encrypting filesystems with block size < page size. Without removing support for block size == page size ;-)