From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:36038 "EHLO
        ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750752AbeAOWgy (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Mon, 15 Jan 2018 17:36:54 -0500
Date: Mon, 15 Jan 2018 22:36:45 +0000
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Michael Thayer <michael.thayer@oracle.com>,
        Larry Finger <Larry.Finger@lwfinger.net>,
        Christoph Hellwig <hch@infradead.org>,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2] fs: Add VirtualBox guest shared folder (vboxsf)
 support
Message-ID: <20180115223644.GN13338@ZenIV.linux.org.uk>
References: <20180115175116.4130-1-hdegoede@redhat.com>
 <20180115175116.4130-2-hdegoede@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180115175116.4130-2-hdegoede@redhat.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

* what hch said about mount options.  Get rid of that before the thing
  goes into mainline.

* all "inode = GET_F_DENTRY(f)->d_inode;" are complete BS; it's called
  file_inode(f).  Kill GET_F_DENTRY() off and be done with that.

* your ->rename() can race with ->get_link().  Look at the place where
  the former reassigns ->path and frees the old value and think what
  happens if the latter is called just prior to that kfree().

* the same goes for sf_inode_revalidate() vs. rename().

* just what happens to ->path of inode when e.g. its grandparent
  directory is renamed?

* AFAICS, you consider all negative dentries invalid.  Why do you even
  hash them, then?