From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-he1eur01on0129.outbound.protection.outlook.com ([104.47.0.129]:48160 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751588AbeA2VJX (ORCPT ); Mon, 29 Jan 2018 16:09:23 -0500 Date: Mon, 29 Jan 2018 13:09:07 -0800 From: Andrei Vagin To: Alexey Dobriyan Cc: Andrei Vagin , linux-fsdevel@vger.kernel.org, Andrew Morton , KAMEZAWA Hiroyuki Subject: Re: [PATCH 1/4] proc: add seq_put_decimal_ull_align to speed up /proc/pid/smaps Message-ID: <20180129210906.GA30738@outlook.office365.com> References: <20180129080043.14191-1-avagin@openvz.org> <20180129191041.GA6186@avx2> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20180129191041.GA6186@avx2> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Jan 29, 2018 at 10:10:42PM +0300, Alexey Dobriyan wrote: > On Mon, Jan 29, 2018 at 12:00:40AM -0800, Andrei Vagin wrote: > > seq_put_decimal_ull_align(m, str, val, width) is equivalent of > > seq_printf(m, "%s%*d", str, width, val), but it works much faster. > > It is called "minimum width", not alignment. Yes, you are right. And it's used to align numbers in output files. Maybe you could suggest a better name for this function? Thanks, Andrei