From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
netdev@vger.kernel.org
Subject: [git pull] reducing kernel_recvmsg() use
Date: Tue, 30 Jan 2018 21:33:26 +0000 [thread overview]
Message-ID: <20180130213326.GD29051@ZenIV.linux.org.uk> (raw)
kernel_recvmsg() is a set_fs()-using wrapper for
sock_recvmsg(). In all but one case that is not needed -
use of ITER_KVEC for ->msg_iter takes care of the data
and does not care about set_fs(). The only exception is
svc_udp_recvfrom() where we want cmsg to be store into
kernel object; everything else can just use sock_recvmsg()
and be done with that.
A followup converting svc_udp_recvfrom() away
from set_fs() (and killing kernel_recvmsg() off) is *NOT*
in that one - I'd like to hear what netdev folks think
of the approach proposed in that followup.
The following changes since commit 4fbd8d194f06c8a3fd2af1ce560ddb31f7ec8323:
Linux 4.15-rc1 (2017-11-26 16:01:47 -0800)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.sock_recvmsg
for you to fetch changes up to bc4802736d8b17eddde52e00838c348770f67c19:
tipc: switch to sock_recvmsg() (2017-12-02 20:38:10 -0500)
----------------------------------------------------------------
Al Viro (10):
svc_recvfrom(): switch to sock_recvmsg()
dlm: switch to sock_recvmsg()
ncpfs: switch to sock_recvmsg()
cfs2: switch to sock_recvmsg()
lustre lnet_sock_read(): switch to sock_recvmsg()
drbd: switch to sock_recvmsg()
mISDN: switch to sock_recvmsg()
ipvs: switch to sock_recvmsg()
smc: switch to sock_recvmsg()
tipc: switch to sock_recvmsg()
drivers/block/drbd/drbd_main.c | 8 +-------
drivers/block/drbd/drbd_receiver.c | 3 ++-
drivers/isdn/mISDN/l1oip_core.c | 22 +++++++++-------------
drivers/staging/lustre/lnet/lnet/lib-socket.c | 24 +++++++++++-------------
fs/dlm/lowcomms.c | 4 ++--
fs/ncpfs/sock.c | 3 ++-
fs/ocfs2/cluster/tcp.c | 3 ++-
net/netfilter/ipvs/ip_vs_sync.c | 9 +++------
net/smc/smc_clc.c | 18 ++++++++++--------
net/sunrpc/svcsock.c | 4 ++--
net/tipc/server.c | 4 ++--
11 files changed, 46 insertions(+), 56 deletions(-)
reply other threads:[~2018-01-30 21:33 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180130213326.GD29051@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).