From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com ([74.125.82.42]:51018 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752733AbeAaQ5M (ORCPT ); Wed, 31 Jan 2018 11:57:12 -0500 Received: by mail-wm0-f42.google.com with SMTP id f71so431698wmf.0 for ; Wed, 31 Jan 2018 08:57:11 -0800 (PST) Date: Wed, 31 Jan 2018 19:57:08 +0300 From: Alexey Dobriyan To: Andrei Vagin Cc: Andrei Vagin , linux-fsdevel@vger.kernel.org, Andrew Morton , KAMEZAWA Hiroyuki Subject: Re: [PATCH 1/4] proc: add seq_put_decimal_ull_align to speed up /proc/pid/smaps Message-ID: <20180131165708.GA2486@avx2> References: <20180129080043.14191-1-avagin@openvz.org> <20180129191041.GA6186@avx2> <20180129210906.GA30738@outlook.office365.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180129210906.GA30738@outlook.office365.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Jan 29, 2018 at 01:09:07PM -0800, Andrei Vagin wrote: > On Mon, Jan 29, 2018 at 10:10:42PM +0300, Alexey Dobriyan wrote: > > On Mon, Jan 29, 2018 at 12:00:40AM -0800, Andrei Vagin wrote: > > > seq_put_decimal_ull_align(m, str, val, width) is equivalent of > > > seq_printf(m, "%s%*d", str, width, val), but it works much faster. > > > > It is called "minimum width", not alignment. > > Yes, you are right. And it's used to align numbers in output files. > > Maybe you could suggest a better name for this function? I honestly don't know. Contemplating printing integers backwards.