From: Andrei Vagin <avagin@virtuozzo.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
Andrei Vagin <avagin@openvz.org>,
linux-fsdevel@vger.kernel.org,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH 1/4] proc: add seq_put_decimal_ull_align to speed up /proc/pid/smaps
Date: Mon, 12 Feb 2018 00:06:14 -0800 [thread overview]
Message-ID: <20180212080612.GA7947@outlook.office365.com> (raw)
In-Reply-To: <20180208161825.bc129ccf769b6c1147efb062@linux-foundation.org>
On Thu, Feb 08, 2018 at 04:18:25PM -0800, Andrew Morton wrote:
> On Mon, 29 Jan 2018 13:09:07 -0800 Andrei Vagin <avagin@virtuozzo.com> wrote:
>
> > On Mon, Jan 29, 2018 at 10:10:42PM +0300, Alexey Dobriyan wrote:
> > > On Mon, Jan 29, 2018 at 12:00:40AM -0800, Andrei Vagin wrote:
> > > > seq_put_decimal_ull_align(m, str, val, width) is equivalent of
> > > > seq_printf(m, "%s%*d", str, width, val), but it works much faster.
> > >
> > > It is called "minimum width", not alignment.
> >
> > Yes, you are right. And it's used to align numbers in output files.
> >
> > Maybe you could suggest a better name for this function?
> >
>
> _width? _min_width_? _pad?
I chose the first one. Thank you. The second version of these patches
has to be in your mailbox.
Thanks,
Andrei
prev parent reply other threads:[~2018-02-12 8:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-29 8:00 [PATCH 1/4] proc: add seq_put_decimal_ull_align to speed up /proc/pid/smaps Andrei Vagin
2018-01-29 8:00 ` [PATCH 2/4] proc: replace seq_printf on seq_putc " Andrei Vagin
2018-01-29 8:00 ` [PATCH 3/4] proc: optimize single-symbol delimiters to spead up seq_put_decimal_ull Andrei Vagin
2018-01-29 8:00 ` [PATCH 4/4] proc: replace seq_printf by seq_put_smth to speed up /proc/pid/status Andrei Vagin
2018-01-29 19:10 ` [PATCH 1/4] proc: add seq_put_decimal_ull_align to speed up /proc/pid/smaps Alexey Dobriyan
2018-01-29 21:09 ` Andrei Vagin
2018-01-31 16:57 ` Alexey Dobriyan
2018-02-09 0:18 ` Andrew Morton
2018-02-12 8:06 ` Andrei Vagin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180212080612.GA7947@outlook.office365.com \
--to=avagin@virtuozzo.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=avagin@openvz.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).