From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-eopbgr10091.outbound.protection.outlook.com ([40.107.1.91]:47376 "EHLO EUR02-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751367AbeBLIG3 (ORCPT ); Mon, 12 Feb 2018 03:06:29 -0500 Date: Mon, 12 Feb 2018 00:06:14 -0800 From: Andrei Vagin To: Andrew Morton Cc: Alexey Dobriyan , Andrei Vagin , linux-fsdevel@vger.kernel.org, KAMEZAWA Hiroyuki Subject: Re: [PATCH 1/4] proc: add seq_put_decimal_ull_align to speed up /proc/pid/smaps Message-ID: <20180212080612.GA7947@outlook.office365.com> References: <20180129080043.14191-1-avagin@openvz.org> <20180129191041.GA6186@avx2> <20180129210906.GA30738@outlook.office365.com> <20180208161825.bc129ccf769b6c1147efb062@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20180208161825.bc129ccf769b6c1147efb062@linux-foundation.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Feb 08, 2018 at 04:18:25PM -0800, Andrew Morton wrote: > On Mon, 29 Jan 2018 13:09:07 -0800 Andrei Vagin wrote: > > > On Mon, Jan 29, 2018 at 10:10:42PM +0300, Alexey Dobriyan wrote: > > > On Mon, Jan 29, 2018 at 12:00:40AM -0800, Andrei Vagin wrote: > > > > seq_put_decimal_ull_align(m, str, val, width) is equivalent of > > > > seq_printf(m, "%s%*d", str, width, val), but it works much faster. > > > > > > It is called "minimum width", not alignment. > > > > Yes, you are right. And it's used to align numbers in output files. > > > > Maybe you could suggest a better name for this function? > > > > _width? _min_width_? _pad? I chose the first one. Thank you. The second version of these patches has to be in your mailbox. Thanks, Andrei