From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f172.google.com ([209.85.128.172]:45627 "EHLO mail-wr0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751533AbeBZTce (ORCPT ); Mon, 26 Feb 2018 14:32:34 -0500 Received: by mail-wr0-f172.google.com with SMTP id p104so22402854wrc.12 for ; Mon, 26 Feb 2018 11:32:33 -0800 (PST) Date: Mon, 26 Feb 2018 20:32:25 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Jan Kara , Steve Kenton , =?utf-8?Q?Vojt=C4=9Bch?= Vladyka , linux-fsdevel@vger.kernel.org Subject: UDF & open integrity type Message-ID: <20180226193225.k2og3lu6dw46h74w@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="2yqlj6riwz3ciwws" Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: --2yqlj6riwz3ciwws Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! After doing more experiments with UDF Integrity Type stored in UDF Logical Volume Integrity Descriptor, it looks like for me that kernel udf fs driver does not implement handling of open integrity correctly. Open Integrity Type (except on VAT disk) mean that filesystem was last time improperly unmounted, e.g. removable media was disconnected when some write operation was in progress or when umount on Linux was not issued. Filesystem with Open Integrity type should be checked for error and ideally also repaired prior next write (or maybe also read) operations. Probably Open Integrity type can be treated on Linux as Dirty bit in FAT filesystem. But it looks like that kernel udf driver automatically change Open Integrity Type to Closed when doing unmount, even when Type was Open prior to UDF mount. For me it does not seem to be correct as kernel itself does not implement any repair/recovery for UDF filesystem and automatically lost any information that chkdsk/fsck should be run. As there is planned fsck.udf, it is really important to have correct information of successful umount command stored in filesystem itself. This can help fsck to know last state of filesystem, like Dirty bit in FAT or clean state of journal for ext*. --=20 Pali Roh=C3=A1r pali.rohar@gmail.com --2yqlj6riwz3ciwws Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQS4VrIQdKium2krgIWL8Mk9A+RDUgUCWpRgwAAKCRCL8Mk9A+RD UuyMAJ4/tlWg5amM+cc7OMnqsc+uZy/53QCbBx4QoHuiCMjFGbhSXiJ5+KG2c+c= =4MRJ -----END PGP SIGNATURE----- --2yqlj6riwz3ciwws--