From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: Kees Cook <keescook@chromium.org>
Cc: Danilo Krummrich <danilokrummrich@dk-develop.de>,
"Luis R. Rodriguez" <mcgrof@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2 2/2] fs/sysctl: remove redundant link check in proc_sys_link_fill_cache()
Date: Wed, 28 Feb 2018 01:15:57 +0000 [thread overview]
Message-ID: <20180228011557.GC14069@wotan.suse.de> (raw)
In-Reply-To: <CAGXu5jLs2Fu+0yUNE4v6+xkfLXdEBs2QY=HctVFGfd__vNPW1g@mail.gmail.com>
On Tue, Feb 27, 2018 at 03:41:40PM -0800, Kees Cook wrote:
> On Tue, Feb 27, 2018 at 3:31 PM, Danilo Krummrich
> <danilokrummrich@dk-develop.de> wrote:
> > proc_sys_link_fill_cache() does not need to check whether we're
> > called for a link - it's already done by scan().
> >
> > Signed-off-by: Danilo Krummrich <danilokrummrich@dk-develop.de>
>
> Acked-by: Kees Cook <keescook@chromium.org>
>
> > ---
> > v2: removed 'err' as it's only used for sysctl_follow_link()
>
> Thanks :)
>
> Luis, do you have a tree for sysctl, or should these just go via -mm?
-mm has been working beautifully so far.
Now that acks have been collected, Danilo, can you also add the other tags
mentioned and resubmit and add akpm@linux-foundation.org ?
Luis
next prev parent reply other threads:[~2018-02-28 1:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 23:31 [PATCH v2 1/2] fs/sysctl: fix potential page fault while unregistering sysctl table Danilo Krummrich
2018-02-27 23:31 ` [PATCH v2 2/2] fs/sysctl: remove redundant link check in proc_sys_link_fill_cache() Danilo Krummrich
2018-02-27 23:41 ` Kees Cook
2018-02-28 1:15 ` Luis R. Rodriguez [this message]
2018-02-27 23:39 ` [PATCH v2 1/2] fs/sysctl: fix potential page fault while unregistering sysctl table Kees Cook
2018-02-28 1:09 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180228011557.GC14069@wotan.suse.de \
--to=mcgrof@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=danilokrummrich@dk-develop.de \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).