From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ipmail06.adl2.internode.on.net ([150.101.137.129]:61892 "EHLO ipmail06.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1162460AbeCAWMF (ORCPT ); Thu, 1 Mar 2018 17:12:05 -0500 Date: Fri, 2 Mar 2018 09:12:02 +1100 From: Dave Chinner To: Christoph Hellwig Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, Theodore Ts'o Subject: Re: [PATCH 2/2] xfs: implement the lazytime mount option Message-ID: <20180301221202.GO30854@dastard> References: <20180228175737.317-1-hch@lst.de> <20180228175737.317-3-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180228175737.317-3-hch@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Feb 28, 2018 at 09:57:37AM -0800, Christoph Hellwig wrote: > Use the VFS dirty inode tracking for lazytime inodes only, and just > log them in ->dirty_inode. > > Signed-off-by: Christoph Hellwig Works fine. I can't think of a cleaner way to implement this, so it looks good to me. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com