* [PATCH] inode: don't memset the inode address space twice
@ 2018-03-01 22:34 Dave Chinner
2018-03-02 9:15 ` Carlos Maiolino
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Dave Chinner @ 2018-03-01 22:34 UTC (permalink / raw)
To: linux-fsdevel; +Cc: linux-xfs
From: Dave Chinner <dchinner@redhat.com>
Noticed when looking at why cycling 600k inodes/s through the inode
cache was taking a total of 8% cpu in memset() during inode
initialisation. There is no need to zero the inode.i_data structure
twice.
This increases single threaded bulkstat throughput from ~200,000
inodes/s to ~220,000 inodes/s, so we save a substantial amount of
CPU time per inode init by doing this.
Signed-Off-By: Dave Chinner <dchinner@redhat.com>
---
fs/inode.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/fs/inode.c b/fs/inode.c
index 6295f1415761..b153aeaa61ea 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -346,9 +346,8 @@ void inc_nlink(struct inode *inode)
}
EXPORT_SYMBOL(inc_nlink);
-void address_space_init_once(struct address_space *mapping)
+static void __address_space_init_once(struct address_space *mapping)
{
- memset(mapping, 0, sizeof(*mapping));
INIT_RADIX_TREE(&mapping->page_tree, GFP_ATOMIC | __GFP_ACCOUNT);
spin_lock_init(&mapping->tree_lock);
init_rwsem(&mapping->i_mmap_rwsem);
@@ -356,6 +355,12 @@ void address_space_init_once(struct address_space *mapping)
spin_lock_init(&mapping->private_lock);
mapping->i_mmap = RB_ROOT_CACHED;
}
+
+void address_space_init_once(struct address_space *mapping)
+{
+ memset(mapping, 0, sizeof(*mapping));
+ __address_space_init_once(mapping);
+}
EXPORT_SYMBOL(address_space_init_once);
/*
@@ -371,7 +376,7 @@ void inode_init_once(struct inode *inode)
INIT_LIST_HEAD(&inode->i_io_list);
INIT_LIST_HEAD(&inode->i_wb_list);
INIT_LIST_HEAD(&inode->i_lru);
- address_space_init_once(&inode->i_data);
+ __address_space_init_once(&inode->i_data);
i_size_ordered_init(inode);
}
EXPORT_SYMBOL(inode_init_once);
--
2.16.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] inode: don't memset the inode address space twice
2018-03-01 22:34 [PATCH] inode: don't memset the inode address space twice Dave Chinner
@ 2018-03-02 9:15 ` Carlos Maiolino
2018-03-06 10:57 ` Jan Kara
2018-03-07 1:32 ` Darrick J. Wong
2 siblings, 0 replies; 4+ messages in thread
From: Carlos Maiolino @ 2018-03-02 9:15 UTC (permalink / raw)
To: Dave Chinner; +Cc: linux-fsdevel, linux-xfs
On Fri, Mar 02, 2018 at 09:34:02AM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Noticed when looking at why cycling 600k inodes/s through the inode
> cache was taking a total of 8% cpu in memset() during inode
> initialisation. There is no need to zero the inode.i_data structure
> twice.
>
> This increases single threaded bulkstat throughput from ~200,000
> inodes/s to ~220,000 inodes/s, so we save a substantial amount of
> CPU time per inode init by doing this.
>
> Signed-Off-By: Dave Chinner <dchinner@redhat.com>
Looks good to me.
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
> ---
> fs/inode.c | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/fs/inode.c b/fs/inode.c
> index 6295f1415761..b153aeaa61ea 100644
> --- a/fs/inode.c
> +++ b/fs/inode.c
> @@ -346,9 +346,8 @@ void inc_nlink(struct inode *inode)
> }
> EXPORT_SYMBOL(inc_nlink);
>
> -void address_space_init_once(struct address_space *mapping)
> +static void __address_space_init_once(struct address_space *mapping)
> {
> - memset(mapping, 0, sizeof(*mapping));
> INIT_RADIX_TREE(&mapping->page_tree, GFP_ATOMIC | __GFP_ACCOUNT);
> spin_lock_init(&mapping->tree_lock);
> init_rwsem(&mapping->i_mmap_rwsem);
> @@ -356,6 +355,12 @@ void address_space_init_once(struct address_space *mapping)
> spin_lock_init(&mapping->private_lock);
> mapping->i_mmap = RB_ROOT_CACHED;
> }
> +
> +void address_space_init_once(struct address_space *mapping)
> +{
> + memset(mapping, 0, sizeof(*mapping));
> + __address_space_init_once(mapping);
> +}
> EXPORT_SYMBOL(address_space_init_once);
>
> /*
> @@ -371,7 +376,7 @@ void inode_init_once(struct inode *inode)
> INIT_LIST_HEAD(&inode->i_io_list);
> INIT_LIST_HEAD(&inode->i_wb_list);
> INIT_LIST_HEAD(&inode->i_lru);
> - address_space_init_once(&inode->i_data);
> + __address_space_init_once(&inode->i_data);
> i_size_ordered_init(inode);
> }
> EXPORT_SYMBOL(inode_init_once);
> --
> 2.16.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Carlos
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] inode: don't memset the inode address space twice
2018-03-01 22:34 [PATCH] inode: don't memset the inode address space twice Dave Chinner
2018-03-02 9:15 ` Carlos Maiolino
@ 2018-03-06 10:57 ` Jan Kara
2018-03-07 1:32 ` Darrick J. Wong
2 siblings, 0 replies; 4+ messages in thread
From: Jan Kara @ 2018-03-06 10:57 UTC (permalink / raw)
To: Dave Chinner; +Cc: linux-fsdevel, linux-xfs
On Fri 02-03-18 09:34:02, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Noticed when looking at why cycling 600k inodes/s through the inode
> cache was taking a total of 8% cpu in memset() during inode
> initialisation. There is no need to zero the inode.i_data structure
> twice.
>
> This increases single threaded bulkstat throughput from ~200,000
> inodes/s to ~220,000 inodes/s, so we save a substantial amount of
> CPU time per inode init by doing this.
>
> Signed-Off-By: Dave Chinner <dchinner@redhat.com>
Nice and the patch looks good. You can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/inode.c | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/fs/inode.c b/fs/inode.c
> index 6295f1415761..b153aeaa61ea 100644
> --- a/fs/inode.c
> +++ b/fs/inode.c
> @@ -346,9 +346,8 @@ void inc_nlink(struct inode *inode)
> }
> EXPORT_SYMBOL(inc_nlink);
>
> -void address_space_init_once(struct address_space *mapping)
> +static void __address_space_init_once(struct address_space *mapping)
> {
> - memset(mapping, 0, sizeof(*mapping));
> INIT_RADIX_TREE(&mapping->page_tree, GFP_ATOMIC | __GFP_ACCOUNT);
> spin_lock_init(&mapping->tree_lock);
> init_rwsem(&mapping->i_mmap_rwsem);
> @@ -356,6 +355,12 @@ void address_space_init_once(struct address_space *mapping)
> spin_lock_init(&mapping->private_lock);
> mapping->i_mmap = RB_ROOT_CACHED;
> }
> +
> +void address_space_init_once(struct address_space *mapping)
> +{
> + memset(mapping, 0, sizeof(*mapping));
> + __address_space_init_once(mapping);
> +}
> EXPORT_SYMBOL(address_space_init_once);
>
> /*
> @@ -371,7 +376,7 @@ void inode_init_once(struct inode *inode)
> INIT_LIST_HEAD(&inode->i_io_list);
> INIT_LIST_HEAD(&inode->i_wb_list);
> INIT_LIST_HEAD(&inode->i_lru);
> - address_space_init_once(&inode->i_data);
> + __address_space_init_once(&inode->i_data);
> i_size_ordered_init(inode);
> }
> EXPORT_SYMBOL(inode_init_once);
> --
> 2.16.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] inode: don't memset the inode address space twice
2018-03-01 22:34 [PATCH] inode: don't memset the inode address space twice Dave Chinner
2018-03-02 9:15 ` Carlos Maiolino
2018-03-06 10:57 ` Jan Kara
@ 2018-03-07 1:32 ` Darrick J. Wong
2 siblings, 0 replies; 4+ messages in thread
From: Darrick J. Wong @ 2018-03-07 1:32 UTC (permalink / raw)
To: Dave Chinner; +Cc: linux-fsdevel, linux-xfs
On Fri, Mar 02, 2018 at 09:34:02AM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Noticed when looking at why cycling 600k inodes/s through the inode
> cache was taking a total of 8% cpu in memset() during inode
> initialisation. There is no need to zero the inode.i_data structure
> twice.
>
> This increases single threaded bulkstat throughput from ~200,000
> inodes/s to ~220,000 inodes/s, so we save a substantial amount of
> CPU time per inode init by doing this.
>
> Signed-Off-By: Dave Chinner <dchinner@redhat.com>
Looks ok, will test...
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/inode.c | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/fs/inode.c b/fs/inode.c
> index 6295f1415761..b153aeaa61ea 100644
> --- a/fs/inode.c
> +++ b/fs/inode.c
> @@ -346,9 +346,8 @@ void inc_nlink(struct inode *inode)
> }
> EXPORT_SYMBOL(inc_nlink);
>
> -void address_space_init_once(struct address_space *mapping)
> +static void __address_space_init_once(struct address_space *mapping)
> {
> - memset(mapping, 0, sizeof(*mapping));
> INIT_RADIX_TREE(&mapping->page_tree, GFP_ATOMIC | __GFP_ACCOUNT);
> spin_lock_init(&mapping->tree_lock);
> init_rwsem(&mapping->i_mmap_rwsem);
> @@ -356,6 +355,12 @@ void address_space_init_once(struct address_space *mapping)
> spin_lock_init(&mapping->private_lock);
> mapping->i_mmap = RB_ROOT_CACHED;
> }
> +
> +void address_space_init_once(struct address_space *mapping)
> +{
> + memset(mapping, 0, sizeof(*mapping));
> + __address_space_init_once(mapping);
> +}
> EXPORT_SYMBOL(address_space_init_once);
>
> /*
> @@ -371,7 +376,7 @@ void inode_init_once(struct inode *inode)
> INIT_LIST_HEAD(&inode->i_io_list);
> INIT_LIST_HEAD(&inode->i_wb_list);
> INIT_LIST_HEAD(&inode->i_lru);
> - address_space_init_once(&inode->i_data);
> + __address_space_init_once(&inode->i_data);
> i_size_ordered_init(inode);
> }
> EXPORT_SYMBOL(inode_init_once);
> --
> 2.16.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-03-07 1:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-01 22:34 [PATCH] inode: don't memset the inode address space twice Dave Chinner
2018-03-02 9:15 ` Carlos Maiolino
2018-03-06 10:57 ` Jan Kara
2018-03-07 1:32 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).