From: Christoph Hellwig <hch@lst.de>
To: viro@zeniv.linux.org.uk
Cc: Avi Kivity <avi@scylladb.com>,
linux-aio@kvack.org, linux-fsdevel@vger.kernel.org,
netdev@vger.kernel.org, linux-api@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 06/28] aio: implement IOCB_CMD_POLL
Date: Wed, 21 Mar 2018 08:40:10 +0100 [thread overview]
Message-ID: <20180321074032.14211-7-hch@lst.de> (raw)
In-Reply-To: <20180321074032.14211-1-hch@lst.de>
Simple one-shot poll through the io_submit() interface. To poll for
a file descriptor the application should submit an iocb of type
IOCB_CMD_POLL. It will poll the fd for the events specified in the
the first 32 bits of the aio_buf field of the iocb.
Unlike poll or epoll without EPOLLONESHOT this interface always works
in one shot mode, that is once the iocb is completed, it will have to be
resubmitted.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Jeff Moyer <jmoyer@redhat.com>
---
fs/aio.c | 102 ++++++++++++++++++++++++++++++++++++++++++-
include/uapi/linux/aio_abi.h | 6 +--
2 files changed, 103 insertions(+), 5 deletions(-)
diff --git a/fs/aio.c b/fs/aio.c
index 79d3eb3d2dd9..38b408129697 100644
--- a/fs/aio.c
+++ b/fs/aio.c
@@ -5,6 +5,7 @@
* Implements an efficient asynchronous io interface.
*
* Copyright 2000, 2001, 2002 Red Hat, Inc. All Rights Reserved.
+ * Copyright 2018 Christoph Hellwig.
*
* See ../COPYING for licensing terms.
*/
@@ -162,10 +163,18 @@ struct fsync_iocb {
bool datasync;
};
+struct poll_iocb {
+ struct file *file;
+ __poll_t events;
+ struct wait_queue_head *head;
+ struct wait_queue_entry wait;
+};
+
struct aio_kiocb {
union {
struct kiocb rw;
struct fsync_iocb fsync;
+ struct poll_iocb poll;
};
struct kioctx *ki_ctx;
@@ -1590,7 +1599,6 @@ static int aio_fsync(struct fsync_iocb *req, struct iocb *iocb, bool datasync)
return -EINVAL;
if (iocb->aio_offset || iocb->aio_nbytes || iocb->aio_rw_flags)
return -EINVAL;
-
req->file = fget(iocb->aio_fildes);
if (unlikely(!req->file))
return -EBADF;
@@ -1609,6 +1617,96 @@ static int aio_fsync(struct fsync_iocb *req, struct iocb *iocb, bool datasync)
return ret;
}
+static void __aio_complete_poll(struct poll_iocb *req, __poll_t mask)
+{
+ fput(req->file);
+ aio_complete(container_of(req, struct aio_kiocb, poll),
+ mangle_poll(mask), 0);
+}
+
+static void aio_complete_poll(struct poll_iocb *req, __poll_t mask)
+{
+ struct aio_kiocb *iocb = container_of(req, struct aio_kiocb, poll);
+
+ if (!(iocb->flags & AIO_IOCB_CANCELLED))
+ __aio_complete_poll(req, mask);
+}
+
+static int aio_poll_cancel(struct kiocb *rw)
+{
+ struct aio_kiocb *iocb = container_of(rw, struct aio_kiocb, rw);
+
+ remove_wait_queue(iocb->poll.head, &iocb->poll.wait);
+ __aio_complete_poll(&iocb->poll, 0); /* no events to report */
+ return 0;
+}
+
+static int aio_poll_wake(struct wait_queue_entry *wait, unsigned mode, int sync,
+ void *key)
+{
+ struct poll_iocb *req = container_of(wait, struct poll_iocb, wait);
+ struct file *file = req->file;
+ __poll_t mask = key_to_poll(key);
+
+ assert_spin_locked(&req->head->lock);
+
+ /* for instances that support it check for an event match first: */
+ if (mask && !(mask & req->events))
+ return 0;
+
+ mask = vfs_poll_mask(file, req->events);
+ if (!mask)
+ return 0;
+
+ __remove_wait_queue(req->head, &req->wait);
+ aio_complete_poll(req, mask);
+ return 1;
+}
+
+static ssize_t aio_poll(struct aio_kiocb *aiocb, struct iocb *iocb)
+{
+ struct poll_iocb *req = &aiocb->poll;
+ unsigned long flags;
+ __poll_t mask;
+
+ /* reject any unknown events outside the normal event mask. */
+ if ((u16)iocb->aio_buf != iocb->aio_buf)
+ return -EINVAL;
+ /* reject fields that are not defined for poll */
+ if (iocb->aio_offset || iocb->aio_nbytes || iocb->aio_rw_flags)
+ return -EINVAL;
+
+ req->events = demangle_poll(iocb->aio_buf) | POLLERR | POLLHUP;
+ req->file = fget(iocb->aio_fildes);
+ if (unlikely(!req->file))
+ return -EBADF;
+
+ req->head = vfs_get_poll_head(req->file, req->events);
+ if (!req->head) {
+ fput(req->file);
+ return -EINVAL; /* same as no support for IOCB_CMD_POLL */
+ }
+ if (IS_ERR(req->head)) {
+ mask = PTR_TO_POLL(req->head);
+ goto done;
+ }
+
+ init_waitqueue_func_entry(&req->wait, aio_poll_wake);
+
+ spin_lock_irqsave(&req->head->lock, flags);
+ mask = vfs_poll_mask(req->file, req->events);
+ if (!mask) {
+ __kiocb_set_cancel_fn(aiocb, aio_poll_cancel,
+ AIO_IOCB_DELAYED_CANCEL);
+ __add_wait_queue(req->head, &req->wait);
+ }
+ spin_unlock_irqrestore(&req->head->lock, flags);
+done:
+ if (mask)
+ aio_complete_poll(req, mask);
+ return -EIOCBQUEUED;
+}
+
static int io_submit_one(struct kioctx *ctx, struct iocb __user *user_iocb,
struct iocb *iocb, bool compat)
{
@@ -1677,6 +1775,8 @@ static int io_submit_one(struct kioctx *ctx, struct iocb __user *user_iocb,
break;
case IOCB_CMD_FDSYNC:
ret = aio_fsync(&req->fsync, iocb, true);
+ case IOCB_CMD_POLL:
+ ret = aio_poll(req, iocb);
break;
default:
pr_debug("invalid aio operation %d\n", iocb->aio_lio_opcode);
diff --git a/include/uapi/linux/aio_abi.h b/include/uapi/linux/aio_abi.h
index 2c0a3415beee..ed0185945bb2 100644
--- a/include/uapi/linux/aio_abi.h
+++ b/include/uapi/linux/aio_abi.h
@@ -39,10 +39,8 @@ enum {
IOCB_CMD_PWRITE = 1,
IOCB_CMD_FSYNC = 2,
IOCB_CMD_FDSYNC = 3,
- /* These two are experimental.
- * IOCB_CMD_PREADX = 4,
- * IOCB_CMD_POLL = 5,
- */
+ /* 4 was the experimental IOCB_CMD_PREADX */
+ IOCB_CMD_POLL = 5,
IOCB_CMD_NOOP = 6,
IOCB_CMD_PREADV = 7,
IOCB_CMD_PWRITEV = 8,
--
2.14.2
next prev parent reply other threads:[~2018-03-21 7:40 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 7:40 aio poll and a new in-kernel poll API V6 Christoph Hellwig
2018-03-21 7:40 ` [PATCH 01/28] fs: unexport poll_schedule_timeout Christoph Hellwig
2018-03-21 9:05 ` Greg KH
2018-03-21 7:40 ` [PATCH 02/28] fs: cleanup do_pollfd Christoph Hellwig
2018-03-21 9:06 ` Greg KH
2018-03-21 7:40 ` [PATCH 03/28] fs: update documentation to mention __poll_t Christoph Hellwig
2018-03-21 9:06 ` Greg KH
2018-03-21 16:28 ` Darrick J. Wong
2018-03-21 7:40 ` [PATCH 04/28] fs: add new vfs_poll and file_can_poll helpers Christoph Hellwig
2018-03-21 9:07 ` Greg KH
2018-03-21 7:40 ` [PATCH 05/28] fs: introduce new ->get_poll_head and ->poll_mask methods Christoph Hellwig
2018-03-21 9:08 ` Greg KH
2018-03-21 16:29 ` Darrick J. Wong
2018-03-21 7:40 ` Christoph Hellwig [this message]
2018-03-21 9:09 ` [PATCH 06/28] aio: implement IOCB_CMD_POLL Greg KH
2018-03-21 16:31 ` Darrick J. Wong
2018-03-22 16:52 ` Al Viro
2018-03-22 17:24 ` Christoph Hellwig
2018-03-22 18:16 ` Al Viro
2018-03-23 18:05 ` Christoph Hellwig
2018-03-21 7:40 ` [PATCH 07/28] net: refactor socket_poll Christoph Hellwig
2018-03-21 7:40 ` [PATCH 08/28] net: add support for ->poll_mask in proto_ops Christoph Hellwig
2018-03-21 7:40 ` [PATCH 09/28] net: remove sock_no_poll Christoph Hellwig
2018-03-21 7:40 ` [PATCH 10/28] net/tcp: convert to ->poll_mask Christoph Hellwig
2018-03-21 7:40 ` [PATCH 11/28] net/unix: " Christoph Hellwig
2018-03-21 7:40 ` [PATCH 12/28] net: convert datagram_poll users tp ->poll_mask Christoph Hellwig
2018-03-21 9:11 ` Greg KH
2018-03-21 7:40 ` [PATCH 13/28] net/dccp: convert to ->poll_mask Christoph Hellwig
2018-03-21 7:40 ` [PATCH 14/28] net/atm: " Christoph Hellwig
2018-03-21 7:40 ` [PATCH 15/28] net/vmw_vsock: " Christoph Hellwig
2018-03-21 7:40 ` [PATCH 16/28] net/tipc: " Christoph Hellwig
2018-03-21 7:40 ` [PATCH 17/28] net/sctp: " Christoph Hellwig
2018-03-21 7:40 ` [PATCH 18/28] net/bluetooth: " Christoph Hellwig
2018-03-21 7:40 ` [PATCH 19/28] net/caif: " Christoph Hellwig
2018-03-21 7:40 ` [PATCH 20/28] net/nfc: " Christoph Hellwig
2018-03-21 7:40 ` [PATCH 21/28] net/phonet: " Christoph Hellwig
2018-03-21 7:40 ` [PATCH 22/28] net/iucv: " Christoph Hellwig
2018-03-21 7:40 ` [PATCH 23/28] net/rxrpc: " Christoph Hellwig
2018-03-21 7:40 ` [PATCH 24/28] crypto: af_alg: " Christoph Hellwig
2018-03-21 7:40 ` [PATCH 25/28] pipe: " Christoph Hellwig
2018-03-21 7:40 ` [PATCH 26/28] eventfd: switch " Christoph Hellwig
2018-03-21 7:40 ` [PATCH 27/28] timerfd: convert " Christoph Hellwig
2018-03-21 7:40 ` [PATCH 28/28] random: " Christoph Hellwig
2018-03-21 9:10 ` Greg KH
2018-03-22 13:49 ` Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180321074032.14211-7-hch@lst.de \
--to=hch@lst.de \
--cc=avi@scylladb.com \
--cc=linux-aio@kvack.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).