From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:32982 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751539AbeCUJI0 (ORCPT ); Wed, 21 Mar 2018 05:08:26 -0400 Date: Wed, 21 Mar 2018 10:08:23 +0100 From: Greg KH To: Christoph Hellwig Cc: viro@zeniv.linux.org.uk, Avi Kivity , linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/28] fs: introduce new ->get_poll_head and ->poll_mask methods Message-ID: <20180321090823.GE14085@kroah.com> References: <20180321074032.14211-1-hch@lst.de> <20180321074032.14211-6-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180321074032.14211-6-hch@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Mar 21, 2018 at 08:40:09AM +0100, Christoph Hellwig wrote: > ->get_poll_head returns the waitqueue that the poll operation is going > to sleep on. Note that this means we can only use a single waitqueue > for the poll, unlike some current drivers that use two waitqueues for > different events. But now that we have keyed wakeups and heavily use > those for poll there aren't that many good reason left to keep the > multiple waitqueues, and if there are any ->poll is still around, the > driver just won't support aio poll. > > Signed-off-by: Christoph Hellwig Reviewed-by: Greg Kroah-Hartman