From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from imap.thunk.org ([74.207.234.97]:44520 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752738AbeCVNuD (ORCPT ); Thu, 22 Mar 2018 09:50:03 -0400 Date: Thu, 22 Mar 2018 09:49:58 -0400 From: "Theodore Y. Ts'o" To: Christoph Hellwig Cc: viro@zeniv.linux.org.uk, Avi Kivity , linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 28/28] random: convert to ->poll_mask Message-ID: <20180322134958.GB2852@thunk.org> References: <20180321074032.14211-1-hch@lst.de> <20180321074032.14211-29-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180321074032.14211-29-hch@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Mar 21, 2018 at 08:40:32AM +0100, Christoph Hellwig wrote: > The big change is that random_read_wait and random_write_wait are merged > into a single waitqueue that uses keyed wakeups. Because wait_event_* > doesn't know about that this will lead to occassional spurious wakeups > in _random_read and add_hwgenerator_randomness, but wait_event_* is > designed to handle these and were are not in a a hot path there. > > Signed-off-by: Christoph Hellwig Acked-by: Theodore Ts'o