From: Andrew Lunn <andrew@lunn.ch>
To: Jiri Pirko <jiri@resnulli.us>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"stephen@networkplumber.org" <stephen@networkplumber.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
Ganesh GR <ganeshgr@chelsio.com>,
Nirranjan Kirubaharan <nirranjan@chelsio.com>,
Indranil Choudhury <indranil@chelsio.com>
Subject: Re: [PATCH net-next v2 1/2] fs/crashdd: add API to collect hardware dump in second kernel
Date: Mon, 2 Apr 2018 14:21:40 +0200 [thread overview]
Message-ID: <20180402122140.GB8159@lunn.ch> (raw)
In-Reply-To: <20180402091143.GD3313@nanopsycho>
> >> The sysfs approach proposed here had been dropped in favour exporting
> >> the dumps as ELF notes in /proc/vmcore.
> >>
> >> Will be posting the new patches soon.
> >
> >The concern was actually how you identify which device that came from.
> >Where you read the identifier changes but sysfs or /proc/vmcore the
> >change remains valid.
>
> Yeah. I still don't see how you link the dump and the device.
Hi Jiri
You can see in the third version the core code accept a free form
name. The driver builds a name using the driver name and the adaptor
name.
What i think would be good is to try to have one API to the driver
that can be used for both crash dumps and devlink snapshots. These are
used at different times, but have basically the same purpose, get
state from the device.
Andrew
next prev parent reply other threads:[~2018-04-02 12:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-24 10:56 [PATCH net-next v2 0/2] kernel: add support to collect hardware logs in crash recovery kernel Rahul Lakkireddy
2018-03-24 10:56 ` [PATCH net-next v2 1/2] fs/crashdd: add API to collect hardware dump in second kernel Rahul Lakkireddy
2018-03-25 12:43 ` kbuild test robot
2018-03-30 10:39 ` Jiri Pirko
2018-03-30 10:51 ` Rahul Lakkireddy
2018-03-30 18:42 ` Eric W. Biederman
2018-04-02 9:11 ` Jiri Pirko
2018-04-02 12:21 ` Andrew Lunn [this message]
2018-04-02 12:30 ` Rahul Lakkireddy
2018-04-03 7:04 ` Jiri Pirko
2018-03-30 15:11 ` Andrew Lunn
2018-04-02 9:12 ` Jiri Pirko
2018-04-03 5:43 ` Alex Vesker
2018-04-03 12:35 ` Andrew Lunn
2018-03-24 10:56 ` [PATCH net-next v2 2/2] cxgb4: " Rahul Lakkireddy
2018-03-24 15:18 ` Andrew Lunn
2018-03-24 22:18 ` Thadeu Lima de Souza Cascardo
2018-03-25 0:17 ` Eric W. Biederman
2018-03-24 15:20 ` [PATCH net-next v2 0/2] kernel: add support to collect hardware logs in crash recovery kernel Eric W. Biederman
2018-03-26 13:45 ` Rahul Lakkireddy
2018-03-27 13:17 ` Eric W. Biederman
2018-03-27 15:27 ` Rahul Lakkireddy
2018-03-27 15:59 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180402122140.GB8159@lunn.ch \
--to=andrew@lunn.ch \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=ganeshgr@chelsio.com \
--cc=indranil@chelsio.com \
--cc=jiri@resnulli.us \
--cc=kexec@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nirranjan@chelsio.com \
--cc=rahul.lakkireddy@chelsio.com \
--cc=stephen@networkplumber.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).