From: Matthew Wilcox <willy@infradead.org>
To: Minchan Kim <minchan@kernel.org>
Cc: Chao Yu <yuchao0@huawei.com>, Jaegeuk Kim <jaegeuk@kernel.org>,
Christopher Lameter <cl@linux.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>, Jan Kara <jack@suse.cz>,
Chris Fries <cfries@google.com>,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] mm: workingset: fix NULL ptr dereference
Date: Mon, 9 Apr 2018 19:41:52 -0700 [thread overview]
Message-ID: <20180410024152.GC31282@bombadil.infradead.org> (raw)
In-Reply-To: <20180410023339.GB214542@rodete-desktop-imager.corp.google.com>
On Tue, Apr 10, 2018 at 11:33:39AM +0900, Minchan Kim wrote:
> @@ -522,7 +532,7 @@ EXPORT_SYMBOL(radix_tree_preload);
> */
> int radix_tree_maybe_preload(gfp_t gfp_mask)
> {
> - if (gfpflags_allow_blocking(gfp_mask))
> + if (gfpflags_allow_blocking(gfp_mask) && !(gfp_mask & __GFP_ZERO))
> return __radix_tree_preload(gfp_mask, RADIX_TREE_PRELOAD_SIZE);
> /* Preloading doesn't help anything with this gfp mask, skip it */
> preempt_disable();
No, you've completely misunderstood what's going on in this function.
next prev parent reply other threads:[~2018-04-10 2:41 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180409015815.235943-1-minchan@kernel.org>
[not found] ` <20180409024925.GA21889@bombadil.infradead.org>
[not found] ` <20180409030930.GA214930@rodete-desktop-imager.corp.google.com>
2018-04-09 11:14 ` [PATCH] mm: workingset: fix NULL ptr dereference Matthew Wilcox
2018-04-09 11:25 ` Minchan Kim
2018-04-09 12:25 ` Chao Yu
2018-04-09 12:48 ` Michal Hocko
2018-04-09 13:41 ` Matthew Wilcox
2018-04-09 13:51 ` Christoph Hellwig
2018-04-09 13:52 ` Michal Hocko
2018-04-09 15:34 ` David Sterba
2018-04-09 14:49 ` Minchan Kim
2018-04-09 15:20 ` Matthew Wilcox
2018-04-09 23:04 ` Minchan Kim
2018-04-10 1:12 ` Matthew Wilcox
2018-04-10 2:33 ` Minchan Kim
2018-04-10 2:39 ` Minchan Kim
2018-04-10 2:41 ` Matthew Wilcox [this message]
2018-04-10 2:59 ` Minchan Kim
2018-04-10 8:50 ` Jan Kara
2018-04-10 11:56 ` Matthew Wilcox
2018-04-10 12:38 ` Michal Hocko
2018-04-10 11:53 ` [PATCH v2] " kbuild test robot
2018-04-10 13:11 ` kbuild test robot
2018-04-09 18:38 ` [PATCH] " Jaegeuk Kim
2018-04-09 19:40 ` Matthew Wilcox
2018-04-10 8:26 ` Michal Hocko
2018-04-10 12:05 ` Matthew Wilcox
2018-04-10 12:33 ` Michal Hocko
2018-04-10 12:39 ` Johannes Weiner
2018-04-10 13:28 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180410024152.GC31282@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=cfries@google.com \
--cc=cl@linux.com \
--cc=hannes@cmpxchg.org \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).