From: Matthew Wilcox <willy@infradead.org>
To: Jerome Glisse <jglisse@redhat.com>
Cc: Jeff Layton <jlayton@kernel.org>,
Dave Chinner <david@fromorbit.com>,
linux-mm@kvack.org, lsf-pc@lists.linux-foundation.org,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-block@vger.kernel.org, Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>
Subject: Re: [LSF/MM] schedule suggestion
Date: Thu, 19 Apr 2018 12:56:37 -0700 [thread overview]
Message-ID: <20180419195637.GA14024@bombadil.infradead.org> (raw)
In-Reply-To: <20180419193108.GA4981@redhat.com>
On Thu, Apr 19, 2018 at 03:31:08PM -0400, Jerome Glisse wrote:
> > > Basicly i want a callback in __fd_install(), do_dup2(), dup_fd() and
> > > add void * *private_data; to struct fdtable (also a default array to
> > > struct files_struct). The callback would be part of struct file_operations.
> > > and only call if it exist (os overhead is only for device driver that
> > > care).
> > >
> > > Did i miss something fundamental ? copy_files() call dup_fd() so i
> > > should be all set here.
> > >
> > > I will work on patches i was hoping this would not be too much work.
>
> Well scratch that whole idea, i would need to add a new array to task
> struct which make it a lot less appealing. Hence a better solution is
> to instead have this as part of mm (well indirectly).
It shouldn't be too bad to add a struct radix_tree to the fdtable.
I'm sure we could just not support weird cases like sharing the fdtable
without sharing the mm. Does anyone actually do that?
next prev parent reply other threads:[~2018-04-19 19:56 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 21:19 [LSF/MM] schedule suggestion Jerome Glisse
2018-04-19 0:48 ` Dave Chinner
2018-04-19 1:55 ` Dave Chinner
2018-04-19 14:38 ` Jerome Glisse
2018-04-19 14:43 ` Matthew Wilcox
2018-04-19 16:30 ` Jerome Glisse
2018-04-19 16:58 ` Jeff Layton
2018-04-19 17:26 ` Jerome Glisse
2018-04-19 18:31 ` Jeff Layton
2018-04-19 19:31 ` Jerome Glisse
2018-04-19 19:56 ` Matthew Wilcox [this message]
2018-04-19 20:15 ` Jerome Glisse
2018-04-19 20:25 ` Matthew Wilcox
2018-04-19 20:39 ` Al Viro
2018-04-19 21:08 ` Jerome Glisse
2018-04-19 20:51 ` Al Viro
2018-04-19 20:33 ` Al Viro
2018-04-19 20:58 ` Jerome Glisse
2018-04-19 21:21 ` Al Viro
2018-04-19 21:47 ` Jerome Glisse
2018-04-19 22:13 ` Al Viro
2018-04-19 14:51 ` Chris Mason
2018-04-19 15:07 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180419195637.GA14024@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=david@fromorbit.com \
--cc=hannes@cmpxchg.org \
--cc=jglisse@redhat.com \
--cc=jlayton@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lsf-pc@lists.linux-foundation.org \
--cc=mhocko@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).