From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 24 Apr 2018 04:45:17 -0700 From: Matthew Wilcox To: Souptick Joarder Cc: jack@suse.cz, Al Viro , Ross Zwisler , Andrew Morton , Dan Williams , Michal Hocko , kirill.shutemov@linux.intel.com, linux-fsdevel , Linux-MM , linux-kernel@vger.kernel.org Subject: Re: [PATCH v5] fs: dax: Adding new return type vm_fault_t Message-ID: <20180424114517.GC26636@bombadil.infradead.org> References: <20180423180625.GA16101@jordon-HP-15-Notebook-PC> <20180423194917.GF13383@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: On Tue, Apr 24, 2018 at 11:29:39AM +0530, Souptick Joarder wrote: > On Tue, Apr 24, 2018 at 1:19 AM, Matthew Wilcox wrote: > > On Mon, Apr 23, 2018 at 11:36:25PM +0530, Souptick Joarder wrote: > >> If the insertion of PTE failed because someone else > >> already added a different entry in the mean time, we > >> treat that as success as we assume the same entry was > >> actually inserted. > > > > No, Jan said to *make it a comment*. In the source file. That's why > > he formatted it with the /* */. Not in the changelog. > Sorry, got confused. > > I think this should be fine - > > +/* > +If the insertion of PTE failed because someone else > +already added a different entry in the mean time, we > +treat that as success as we assume the same entry was > +actually inserted. > +*/ Jan literally typed out exactly what you need to insert: /* * If the insertion of PTE failed because someone else already added a * different entry in the mean time, we treat that as success as we assume * the same entry was actually inserted. */ For some reason you've chosen to wrap the lines shorter than Jan had them, and use a different comment formatting style from the rest of the kernel. Why? I'd suggest re-reading Documentation/process/coding-style.rst