linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Omar Sandoval <osandov@osandov.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
	xfs <linux-xfs@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	linux-mm@kvack.org, Aleksei Besogonov <cyberax@amazon.com>
Subject: Re: [PATCH] iomap: add a swapfile activation function
Date: Thu, 26 Apr 2018 00:27:47 -0700	[thread overview]
Message-ID: <20180426072747.GA25194@vader> (raw)
In-Reply-To: <20180426055727.GA24887@infradead.org>

On Wed, Apr 25, 2018 at 10:57:27PM -0700, Christoph Hellwig wrote:
> On Wed, Apr 25, 2018 at 04:46:22PM -0700, Darrick J. Wong wrote:
> > (I mean, we /could/ just treat the swapfile as an unbreakable rdma/dax
> > style lease, but ugh...)
> 
> That is what I think it should be long term, instead of a strange
> parallel I/O path.
> 
> But in the mean time we have a real problem with supporting swap files,
> so we should merge the approaches from you and Aleksei and get something
> in ASAP.

I'm planning to do something along these lines for Btrfs, as well (have
swap_activate add the swap extents itself), because the previous thing I
tried with going through ->read_iter() and ->write_iter() ran into too
many locking issues (i.e., GFP_NOFS can suddenly go through FS locks).

      reply	other threads:[~2018-04-26  7:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-18  2:50 [PATCH] iomap: add a swapfile activation function Darrick J. Wong
2018-04-21 12:33 ` Jan Kara
2018-05-02 20:29   ` Darrick J. Wong
2018-04-24 17:35 ` Christoph Hellwig
2018-04-25 23:46   ` Darrick J. Wong
2018-04-26  5:57     ` Christoph Hellwig
2018-04-26  7:27       ` Omar Sandoval [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180426072747.GA25194@vader \
    --to=osandov@osandov.com \
    --cc=cyberax@amazon.com \
    --cc=darrick.wong@oracle.com \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).