From: Christoph Hellwig <hch@infradead.org>
To: Omar Sandoval <osandov@osandov.com>
Cc: "Darrick J . Wong" <darrick.wong@oracle.com>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Jan Kara <jack@suse.cz>
Subject: Re: [PATCH] iomap: don't allow holes in swapfiles
Date: Wed, 16 May 2018 09:23:29 -0700 [thread overview]
Message-ID: <20180516162329.GA21071@infradead.org> (raw)
In-Reply-To: <e722c29f7291b9c31533fd8b2e84d7f469c3ac88.1526452889.git.osandov@fb.com>
>
> - /* Skip holes. */
> + /* No holes. */
> if (iomap->type == IOMAP_HOLE)
> - goto out;
> + goto err;
If we end up not allowing holes this check can just be removed
entirely. We already check for the allow types below. I have to
admit I would move that type check above the bdev check, though.
next prev parent reply other threads:[~2018-05-16 16:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 6:45 [PATCH] iomap: don't allow holes in swapfiles Omar Sandoval
2018-05-16 15:50 ` Darrick J. Wong
2018-05-16 15:51 ` Christoph Hellwig
2018-05-16 15:56 ` Darrick J. Wong
2018-05-16 16:19 ` Omar Sandoval
2018-05-16 16:24 ` Christoph Hellwig
2018-05-16 16:23 ` Christoph Hellwig [this message]
2018-05-16 16:26 ` Omar Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180516162329.GA21071@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).