From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:35032 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753827AbeERI2n (ORCPT ); Fri, 18 May 2018 04:28:43 -0400 Date: Fri, 18 May 2018 09:28:38 +0100 From: James Hogan To: Christoph Hellwig Cc: viro@zeniv.linux.org.uk, Avi Kivity , linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/7] aio: implement io_pgetevents Message-ID: <20180518082837.GA3264@jamesdev> References: <20180502211448.18276-1-hch@lst.de> <20180502211448.18276-8-hch@lst.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vtzGhvizbBRQ85DL" Content-Disposition: inline In-Reply-To: <20180502211448.18276-8-hch@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: --vtzGhvizbBRQ85DL Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Given this: On Wed, May 02, 2018 at 11:14:48PM +0200, Christoph Hellwig wrote: > +struct __aio_sigset { > + sigset_t __user *sigmask; > + size_t sigsetsize; > +}; and: > +asmlinkage long sys_io_pgetevents(aio_context_t ctx_id, > + long min_nr, > + long nr, > + struct io_event __user *events, > + struct timespec __user *timeout, > + const struct __aio_sigset *sig); The following paragraph in the commit message would appear to be misleading since __aio_sigset contains a size: > Note that unlike many other signal related calls we do not pass a sigmask > size, as that would get us to 7 arguments, which aren't easily supported > by the syscall infrastructure. It seems a lot less painful to just add a > new syscall variant in the unlikely case we're going to increase the > sigset size. Is it possible to correct it before this gets merged? Thanks James --vtzGhvizbBRQ85DL Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYIAB0WIQS7lRNBWUYtqfDOVL41zuSGKxAj8gUCWv6OtAAKCRA1zuSGKxAj 8nzxAQC7f4RLhmqTHYo86l9+4h8Ta0h4zflObA+py2hwfuGW2wD/a+C9QJzr4ybw XxWoWxP/rKTTnqobNheJw5wH6+HiqgQ= =7rhk -----END PGP SIGNATURE----- --vtzGhvizbBRQ85DL--