From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from bombadil.infradead.org ([198.137.202.133]:60984 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1032233AbeEZSis (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Sat, 26 May 2018 14:38:48 -0400
Date: Sat, 26 May 2018 11:38:43 -0700
From: Matthew Wilcox <willy@infradead.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
        linux-fsdevel@vger.kernel.org
Subject: Re: [RFC][PATCHES] reducing d_add() use, part 3 (procfs)
Message-ID: <20180526183843.GA30188@bombadil.infradead.org>
References: <20180513212612.GV30522@ZenIV.linux.org.uk>
 <20180525235326.GJ30522@ZenIV.linux.org.uk>
 <20180526000302.GK30522@ZenIV.linux.org.uk>
 <20180526130726.GA12809@avx2>
 <20180526135640.GA12618@avx2>
 <20180526182021.GQ30522@ZenIV.linux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180526182021.GQ30522@ZenIV.linux.org.uk>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Sat, May 26, 2018 at 07:20:21PM +0100, Al Viro wrote:
> D'oh...  Incremental would be
> 
> diff --git a/fs/proc/fd.c b/fs/proc/fd.c
> index 694faeacf42f..f5de22a9e9e0 100644
> --- a/fs/proc/fd.c
> +++ b/fs/proc/fd.c
> @@ -247,15 +247,15 @@ static int proc_readfd_common(struct file *file, struct dir_context *ctx,
>  	for (fd = ctx->pos - 2;
>  	     fd < files_fdtable(files)->max_fds;
>  	     fd++, ctx->pos++) {
> -		struct file *file;
> +		struct file *f;

Ugh.  -Wshadow doesn't get turned on until W=2 which is really damn noisy.
It's going to take a _lot_ of work to move that over into W=1 or even
set by default.