From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from verein.lst.de ([213.95.11.211]:54861 "EHLO newverein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752120AbeFDMnW (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
        Mon, 4 Jun 2018 08:43:22 -0400
Date: Mon, 4 Jun 2018 14:50:22 +0200
From: Christoph Hellwig <hch@lst.de>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: cluster-devel@redhat.com, Christoph Hellwig <hch@lst.de>,
        linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v7 07/12] iomap: Add page_write_end iomap hook
Message-ID: <20180604125022.GB30780@lst.de>
References: <20180604123729.23414-1-agruenba@redhat.com> <20180604123729.23414-8-agruenba@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180604123729.23414-8-agruenba@redhat.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Mon, Jun 04, 2018 at 02:37:24PM +0200, Andreas Gruenbacher wrote:
> Add a page_write_end hook called when done writing to a page, for
> filesystems that implement data journaling: in that case, pages are
> written to the journal before being written back to their proper on-disk
> locations.  The new hook is bypassed for IOMAP_INLINE mappings.

I'd rather not bypass it in common code.  Can you pass the iomap
to the callback and then do the bypass in gfs2 to keep it generic?