From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zeniv.linux.org.uk ([195.92.253.2]:59858 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751599AbeFEL0n (ORCPT ); Tue, 5 Jun 2018 07:26:43 -0400 Date: Tue, 5 Jun 2018 12:26:41 +0100 From: Al Viro To: Ilya Matveychikov Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] ksys_mount: check for permissions before resource allocation Message-ID: <20180605112641.GN30522@ZenIV.linux.org.uk> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Jun 05, 2018 at 10:59:51AM +0400, Ilya Matveychikov wrote: > Just CC’ed to some of maintainers. > > $ perl scripts/get_maintainer.pl fs/0001-ksys_mount-check-for-permissions-before-resource-all.patch > Alexander Viro (maintainer:FILESYSTEMS (VFS and infrastructure)) > linux-fsdevel@vger.kernel.org (open list:FILESYSTEMS (VFS and infrastructure)) > linux-kernel@vger.kernel.org (open list) > > > On Jun 5, 2018, at 6:00 AM, Ilya Matveychikov wrote: > > > > Early check for mount permissions prevents possible allocation of 3 > > pages from kmalloc() pool by unpriveledged user which can be used for > > spraying the kernel heap. I'm sorry, but there are arseloads of unpriveleged syscalls that do the same, starting with read() from procfs files. So what the hell does it buy?