From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.133]:46078 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754869AbeFNNmh (ORCPT ); Thu, 14 Jun 2018 09:42:37 -0400 Date: Thu, 14 Jun 2018 06:42:35 -0700 From: Christoph Hellwig To: Bart Van Assche Cc: Damien Le Moal , "mcgrof@kernel.org" , "mwilck@suse.com" , "linux-block@vger.kernel.org" , "agk@redhat.com" , "hare@suse.de" , "axboe@kernel.dk" , "yuchao0@huawei.com" , "ghe@suse.com" , "linux-fsdevel@vger.kernel.org" , "jaegeuk@kernel.org" , "tchvatal@suse.com" , "zren@suse.com" Subject: Re: [PATCH] dm-zoned-tools: add zoned disk udev rules for scheduler / dmsetup Message-ID: <20180614134235.GA21624@infradead.org> References: <20180614001147.1545-1-mcgrof@kernel.org> <791e0a85-be07-4a31-f13d-282a1c94bf22@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Jun 14, 2018 at 01:39:50PM +0000, Bart Van Assche wrote: > On Thu, 2018-06-14 at 10:01 +0000, Damien Le Moal wrote: > > Applied. Thanks Luis ! > > Hello Damien, > > Can this still be undone? I agree with Mike that it's wrong to invoke > "/sbin/dmsetup create ... zoned ..." from a udev rule. Yes. We'll really need to verfify the device has dm-zoned metadata first. Preferably including a uuid for stable device naming.