From: Alexey Dobriyan <adobriyan@gmail.com>
To: dhowells@redhat.com
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] proc: Make inline name size calculation automatic
Date: Thu, 14 Jun 2018 23:09:56 +0300 [thread overview]
Message-ID: <20180614200956.GB7137@avx2> (raw)
> Require a minimum inline name size of 33+1 to allow for names that look
> like two hex numbers with a dash between.
Hi, David.
Why 34? /proc will fallback to separate allocation for name anyway.
I sent nearly identical patch earlier.
https://marc.info/?l=linux-kernel&m=152667374404900&w=4
If you compare, the differences are:
* no BUILD_BUG_ON,
* 64 bytes is too litle even on 32-bit,
* 512 bytes is probably too much even on 64-bit.
> - .name = proc_root.inline_name,
> - .inline_name = "/proc",
> + .name = "/proc",
This will "uninline" 5 bytes wasting space.
next reply other threads:[~2018-06-14 20:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 20:09 Alexey Dobriyan [this message]
2018-06-14 20:30 ` [PATCH] proc: Make inline name size calculation automatic David Howells
2018-06-15 17:15 ` Alexey Dobriyan
2018-06-17 21:57 ` [PATCH] proc: fixup PDE allocation bloat Alexey Dobriyan
2018-07-20 0:06 ` Shakeel Butt
2018-08-17 13:28 ` Alexey Dobriyan
-- strict thread matches above, loose matches on Subject: below --
2018-06-13 18:43 [PATCH] proc: Make inline name size calculation automatic David Howells
2018-06-19 0:42 ` Andrew Morton
2018-06-19 8:01 ` David Howells
2018-06-19 21:59 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180614200956.GB7137@avx2 \
--to=adobriyan@gmail.com \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).