From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f171.google.com ([209.85.128.171]:42972 "EHLO mail-wr0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755265AbeFNUKA (ORCPT ); Thu, 14 Jun 2018 16:10:00 -0400 Date: Thu, 14 Jun 2018 23:09:56 +0300 From: Alexey Dobriyan To: dhowells@redhat.com Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] proc: Make inline name size calculation automatic Message-ID: <20180614200956.GB7137@avx2> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: > Require a minimum inline name size of 33+1 to allow for names that look > like two hex numbers with a dash between. Hi, David. Why 34? /proc will fallback to separate allocation for name anyway. I sent nearly identical patch earlier. https://marc.info/?l=linux-kernel&m=152667374404900&w=4 If you compare, the differences are: * no BUILD_BUG_ON, * 64 bytes is too litle even on 32-bit, * 512 bytes is probably too much even on 64-bit. > - .name = proc_root.inline_name, > - .inline_name = "/proc", > + .name = "/proc", This will "uninline" 5 bytes wasting space.