From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
Andreas Gruenbacher <agruenba@redhat.com>,
linux-xfs@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
linux-fsdevel@vger.kernel.org, cluster-devel@redhat.com,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/6] iomap: move bdev and dax_dev in a union
Date: Tue, 19 Jun 2018 08:44:51 +0200 [thread overview]
Message-ID: <20180619064451.GA24824@lst.de> (raw)
In-Reply-To: <20180619062557.GA21698@magnolia>
On Mon, Jun 18, 2018 at 11:25:57PM -0700, Darrick J. Wong wrote:
> Is this going to blow up iomap_dax_zero? It seems to use both bdev and
> dax_dev on __dax_zero_page_range, which definitely uses both.
>
> (Or did all that get rearranged when I wasn't looking?)
Ouch, it does. And that looks pretty broken.
> Also, I guess this will break iomap swapfiles since it checks
> iomap->bdev which we stop supplying with this patch...
> though I have no idea if DAX swapfiles are even supported.
Not sure if we support it. We didn't use to support it when
swap used ->bmap, so until someone volunteers to test it we
should disable it with the iomap swapfile code as well. But
even then doing a detour through the block layer and thus
the bdev makes very little sense.
>
> What's the harm in supplying both pointers?
Just blowing up the size of the iomap. Especially once we add
the inline data as the third option.
next prev parent reply other threads:[~2018-06-19 6:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 12:04 iomap preparations for GFS2 v2 Christoph Hellwig
2018-06-14 12:04 ` [PATCH 1/6] fs: factor out a __generic_write_end helper Christoph Hellwig
2018-06-14 12:04 ` [PATCH 2/6] iomap: move bdev and dax_dev in a union Christoph Hellwig
2018-06-19 6:25 ` Darrick J. Wong
2018-06-19 6:44 ` Christoph Hellwig [this message]
2018-06-19 6:50 ` Darrick J. Wong
2018-06-14 12:04 ` [PATCH 3/6] iomap: mark newly allocated buffer heads as new Christoph Hellwig
2018-06-14 12:04 ` [PATCH 4/6] iomap: complete partial direct I/O writes synchronously Christoph Hellwig
2018-06-14 12:04 ` [PATCH 5/6] iomap: generic inline data handling Christoph Hellwig
2018-06-14 12:04 ` [PATCH 6/6] iomap: add a page_done callback Christoph Hellwig
2018-06-14 13:04 ` iomap preparations for GFS2 v2 Andreas Gruenbacher
2018-06-15 8:03 ` Christoph Hellwig
2018-06-15 8:31 ` [Cluster-devel] " Steven Whitehouse
2018-06-19 11:08 ` Andreas Gruenbacher
2018-06-19 14:35 ` Christoph Hellwig
2018-06-19 15:14 ` Andreas Gruenbacher
-- strict thread matches above, loose matches on Subject: below --
2018-06-06 10:40 iomap preparations for GFS2 Christoph Hellwig
2018-06-06 10:40 ` [PATCH 2/6] iomap: move bdev and dax_dev in a union Christoph Hellwig
2018-06-06 11:37 ` Andreas Gruenbacher
2018-06-06 12:05 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180619064451.GA24824@lst.de \
--to=hch@lst.de \
--cc=agruenba@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=darrick.wong@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).