From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway21.websitewelcome.com ([192.185.45.133]:32770 "EHLO gateway21.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752870AbeFTNes (ORCPT ); Wed, 20 Jun 2018 09:34:48 -0400 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 5CAFD400D0800 for ; Wed, 20 Jun 2018 08:11:34 -0500 (CDT) Date: Wed, 20 Jun 2018 08:10:59 -0500 From: "Gustavo A. R. Silva" To: David Howells , Alexander Viro Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] fs/super.c: Fix lock/unlock imbalance in sget_fc Message-ID: <20180620131059.GA28925@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: It seems a spin_unlock is missing before return at line 532: return old. Addresses-Coverity-ID: 1470111 ("Missing unlock") Fixes: 4f3911e76e19 ("vfs: Implement a filesystem superblock creation/configuration context") Signed-off-by: Gustavo A. R. Silva --- fs/super.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/super.c b/fs/super.c index 43400f5..ff24532 100644 --- a/fs/super.c +++ b/fs/super.c @@ -529,6 +529,7 @@ struct super_block *sget_fc(struct fs_context *fc, destroy_unused_super(s); s = NULL; } + spin_unlock(&sb_lock); return old; } } -- 2.7.4