From: Matthew Wilcox <willy@infradead.org>
To: Souptick Joarder <jrdr.linux@gmail.com>
Cc: Dan Williams <dan.j.williams@intel.com>, Jan Kara <jack@suse.cz>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Michal Hocko <mhocko@suse.com>,
Andrew Morton <akpm@linux-foundation.org>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>
Subject: Re: [PATCH] include: dax: new-return-type-vm_fault_t
Date: Wed, 20 Jun 2018 10:27:25 -0700 [thread overview]
Message-ID: <20180620172725.GA31068@bombadil.infradead.org> (raw)
In-Reply-To: <CAFqt6zYyE+Bm90CckQvJwfW85Hj2SN-Z6J6DidpgHu3h98Sgfg@mail.gmail.com>
On Wed, Jun 20, 2018 at 10:51:49PM +0530, Souptick Joarder wrote:
> On Wed, Jun 20, 2018 at 10:50 PM, Souptick Joarder <jrdr.linux@gmail.com> wrote:
> > Use new return type vm_fault_t for fault handler. For now,
> > this is just documenting that the function returns a VM_FAULT
> > value rather than an errno. Once all instances are converted,
> > vm_fault_t will become a distinct type.
> As part of
> commit ab77dab46210 ("fs/dax.c: use new return type vm_fault_t")
> I missed this change which leads to compilation error.
> Sorry about it.
>
> This patch need to be in 4.18-rc-2/x on priority.
It only leads to a compilation error for you; the rest of us are still
using typedef int vm_fault_t, so it's not a mismatch. It'd be nice to get
this fixed, but it's not a priority.
Sorry I didn't spot this during my review.
prev parent reply other threads:[~2018-06-20 17:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 17:20 [PATCH] include: dax: new-return-type-vm_fault_t Souptick Joarder
2018-06-20 17:21 ` Souptick Joarder
2018-06-20 17:27 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180620172725.GA31068@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=jack@suse.cz \
--cc=jrdr.linux@gmail.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=ross.zwisler@linux.intel.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).