From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:36934 "EHLO
        ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751471AbeFWVNp (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Sat, 23 Jun 2018 17:13:45 -0400
Date: Sat, 23 Jun 2018 22:13:41 +0100
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Jan Kara <jack@suse.cz>, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v4 1/5] fsnotify: use typedef fsnotify_connp_t for brevity
Message-ID: <20180623211341.GC30522@ZenIV.linux.org.uk>
References: <1529765691-25170-1-git-send-email-amir73il@gmail.com>
 <1529765691-25170-2-git-send-email-amir73il@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1529765691-25170-2-git-send-email-amir73il@gmail.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Sat, Jun 23, 2018 at 05:54:47PM +0300, Amir Goldstein wrote:
> The object marks manipulation functions fsnotify_destroy_marks()
> fsnotify_find_mark() and their helpers take an argument of type
> struct fsnotify_mark_connector __rcu ** to dereference the connector
> pointer. use a typedef to describe this type for brevity.

That kind of typedefs is generally considered a bad style kernel-side...