From: Mike Snitzer <snitzer@redhat.com>
To: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: Toshi Kani <toshi.kani@hpe.com>,
dm-devel@redhat.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH v3 0/3] Fix DM DAX handling
Date: Tue, 26 Jun 2018 14:48:25 -0400 [thread overview]
Message-ID: <20180626184824.GA7114@redhat.com> (raw)
In-Reply-To: <20180626175932.8899-1-ross.zwisler@linux.intel.com>
On Tue, Jun 26 2018 at 1:59pm -0400,
Ross Zwisler <ross.zwisler@linux.intel.com> wrote:
> This series fixes a few issues that I found with DM's handling of DAX
> devices. Here are some of the issues I found:
>
> * We can create a dm-stripe or dm-linear device which is made up of an
> fsdax PMEM namespace and a raw PMEM namespace but which can hold a
> filesystem mounted with the -o dax mount option. DAX operations to
> the raw PMEM namespace part lack struct page and can fail in
> interesting/unexpected ways when doing things like fork(), examining
> memory with gdb, etc.
>
> * We can create a dm-stripe or dm-linear device which is made up of an
> fsdax PMEM namespace and a BRD ramdisk which can hold a filesystem
> mounted with the -o dax mount option. All I/O to this filesystem
> will fail.
>
> ---
>
> Changes since v2:
> * Only set QUEUE_FLAG_DAX for fsdax mode PMEM namespaces. (Mike)
> * Check for QUEUE_FLAG_DAX in __bdev_dax_supported(). (Mike)
> * Get rid of DM_TYPE_DAX_BIO_BASED reworks. (Mike)
> * Dropped the first 2 prep patches of v2 since they were merged for
> v4.18-rc1. (Thanks, Darrick!)
>
> ---
>
> Mike, can you take this series through your tree?
>
> Personally I think this should be treated as a bug fix and merged in the
> v4.18-rc* series.
I'd be fine with staging it for 4.18. Only question is whether others
are fine with the dax patch (and me being the one to get it to Linus)?
I already replied to the 3rd patch with some feedback for v4 (but I can
also take care of those changes if I'm the one to stage these changes).
Maybe if Dan and/or others could provide their review for both the dax
and pmem patches? If I can get review on those I'll get the series
staged for Linus to pull this week.
Thanks,
Mike
prev parent reply other threads:[~2018-06-26 18:48 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-26 17:59 [PATCH v3 0/3] Fix DM DAX handling Ross Zwisler
2018-06-26 17:59 ` [PATCH v3 1/3] pmem: only set QUEUE_FLAG_DAX for fsdax mode Ross Zwisler
2018-06-26 18:52 ` Dan Williams
2018-06-26 18:58 ` Mike Snitzer
2018-06-26 19:07 ` Dan Williams
2018-06-26 19:12 ` Ross Zwisler
2018-06-26 19:13 ` Mike Snitzer
2018-06-26 19:19 ` Dan Williams
2018-06-26 20:54 ` Kani, Toshi
2018-06-26 21:02 ` Dan Williams
2018-06-26 21:23 ` Kani, Toshi
2018-06-26 21:28 ` Dan Williams
2018-06-26 21:31 ` Kani, Toshi
2018-06-26 21:51 ` Dan Williams
2018-06-26 22:04 ` Ross Zwisler
2018-06-28 17:42 ` Kani, Toshi
2018-06-28 17:48 ` Mike Snitzer
2018-06-28 17:59 ` Dan Williams
2018-06-28 18:01 ` Kani, Toshi
2018-06-28 19:04 ` Ross Zwisler
2018-06-28 19:40 ` Kani, Toshi
2018-06-26 19:11 ` Ross Zwisler
2018-06-26 17:59 ` [PATCH v3 2/3] dax: bdev_dax_supported() check for QUEUE_FLAG_DAX Ross Zwisler
2018-06-26 17:59 ` [PATCH v3 3/3] dm: prevent DAX mounts if not supported Ross Zwisler
2018-06-26 18:17 ` Mike Snitzer
2018-06-26 19:01 ` [PATCH v4 " Ross Zwisler
2018-06-26 18:48 ` Mike Snitzer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180626184824.GA7114@redhat.com \
--to=snitzer@redhat.com \
--cc=dm-devel@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ross.zwisler@linux.intel.com \
--cc=toshi.kani@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).