From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:49364 "EHLO
        ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752881AbeGDWiv (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Wed, 4 Jul 2018 18:38:51 -0400
Date: Wed, 4 Jul 2018 23:38:25 +0100
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Ingo Molnar <mingo@kernel.org>
Cc: Dan Williams <dan.j.williams@intel.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Andy Lutomirski <luto@amacapital.net>,
        Borislav Petkov <bp@alien8.de>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Tony Luck <tony.luck@intel.com>,
        Ross Zwisler <ross.zwisler@linux.intel.com>,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        x86@kernel.org
Subject: Re: [PATCH] x86/asm/memcpy_mcsafe: Fix copy_to_user_mcsafe()
 exception handling
Message-ID: <20180704223825.GZ30522@ZenIV.linux.org.uk>
References: <20180702165803.GB19488@linux.intel.com>
 <153056565378.3420.295180898468362039.stgit@dwillia2-desk3.amr.corp.intel.com>
 <20180703083040.GB971@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180703083040.GB971@gmail.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, Jul 03, 2018 at 10:30:40AM +0200, Ingo Molnar wrote:
> 
> * Dan Williams <dan.j.williams@intel.com> wrote:
> 
> > Hi Ingo,
> > 
> > Here is an additional copy_to_iter_mcsafe() fix to address the crash
> > reported by Ross. This now passes xfstests:generic/323 on my system.
> 
> The lib/iov_iter fix would need an Acked-by from Al.

I can live with that; I would really like to see some documentation on
the copy_to_iter_mcsafe(), but that's a separate story.  Incidentally,
are there any expectations of other callers appearing, or is that
(and copy_from_iter_flushcache()) YASingleConsumerAPI?