From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.133]:39556 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754155AbeGFOLm (ORCPT ); Fri, 6 Jul 2018 10:11:42 -0400 Date: Fri, 6 Jul 2018 07:11:41 -0700 From: Matthew Wilcox To: "Gustavo A. R. Silva" Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] xarray: Fix lock/unlock imbalance in xa_alloc Message-ID: <20180706141141.GA20816@bombadil.infradead.org> References: <20180706131044.GA25469@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180706131044.GA25469@embeddedor.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Jul 06, 2018 at 08:10:44AM -0500, Gustavo A. R. Silva wrote: > Release *xa_lock* before return. Thank you! I need to improve the test suite to catch that one.