From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]:51323 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729633AbeGQNsQ (ORCPT ); Tue, 17 Jul 2018 09:48:16 -0400 Date: Tue, 17 Jul 2018 15:18:10 +0200 From: Christoph Hellwig To: Andrew Morton Cc: Viacheslav Dubeyko , Ernesto =?iso-8859-1?Q?A=2E_Fern=E1ndez?= , linux-fsdevel@vger.kernel.org, Christoph Hellwig , Jan Kara Subject: Re: [PATCH] hfsplus: drop ACL support Message-ID: <20180717131810.GE13582@lst.de> References: <20180714190608.wtnmmtjqeyladkut@eaf> <1531595463.5345.1.camel@dubeyko.com> <20180716170748.5264352de39271b67cc54143@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180716170748.5264352de39271b67cc54143@linux-foundation.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Jul 16, 2018 at 05:07:48PM -0700, Andrew Morton wrote: > On Sat, 14 Jul 2018 12:11:03 -0700 Viacheslav Dubeyko wrote: > > > On Sat, 2018-07-14 at 16:06 -0300, Ernesto A. Fern�ndez wrote: > > > The HFS+ Access Control Lists have not worked at all for the past > > > five > > > years, and nobody seems to have noticed. Besides, POSIX draft ACLs > > > are > > > not compatible with MacOS. Drop the feature entirely. > > > > > > > Bugs need to be fixed but not to drop. Otherwise, it needs to drop the > > whole HFS+ support from the kernel. > > Yes, we could make it depend on BROKEN and hope that someone comes > along and fixes it - there's little cost in carrying such a thing. > > Or maybe it can never work for some reason and should indeed be > dropped, I don't know. I was interested in understanding the reasoning > behind hch's ack, but I can't find it on linux-fs-devel. Help? The issue is that hfsplus supports it's own NFSv4-like ACLs, which are nothing like the Posix ACLs supported by the Linux driver. Or in other words: they were always a Linux-only incompatible extension that should never have been merged.