From: Matthew Wilcox <willy@infradead.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Shan Hai <shan.hai@oracle.com>, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/1] iomap: simplify header file include guard macro definition
Date: Tue, 17 Jul 2018 06:47:50 -0700 [thread overview]
Message-ID: <20180717134750.GA30644@bombadil.infradead.org> (raw)
In-Reply-To: <20180717131349.GB13582@lst.de>
On Tue, Jul 17, 2018 at 03:13:49PM +0200, Christoph Hellwig wrote:
> On Mon, Jul 16, 2018 at 03:07:16PM +0800, Shan Hai wrote:
> > The simple definition of a macro is enough for the include guard, it's not
> > necessary to assign a value to it, so remove the assignment.
> >
> > Signed-off-by: Shan Hai <shan.hai@oracle.com>
>
> And what is the exact benefit of changing this?
doesn't seem worthwhile to me either. If anything's going to change,
it should probably be _LINUX_IOMAP_H (insofaras we have a standard for
include guards, a single _ seems to be preferred)
next prev parent reply other threads:[~2018-07-17 14:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 7:07 [PATCH 1/1] iomap: simplify header file include guard macro definition Shan Hai
2018-07-17 13:13 ` Christoph Hellwig
2018-07-17 13:47 ` Matthew Wilcox [this message]
2018-07-17 13:52 ` Shan Hai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180717134750.GA30644@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=shan.hai@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).